Refactoring of compas_robots to COMPAS 2.0 and various updates to prepare for release #1
Conversation
… the new scene/sceneobject classes of 2.0
|
ah wait.. hold on the review, the build is failing horribly for some reason... |
LICENSE
Outdated
| @@ -1,6 +1,6 @@ | |||
| MIT License | |||
|
|
|||
| compas-dev | |||
| Copyright (c) 2023 COMPAS Association | |||
There was a problem hiding this comment.
haha just out of curiosity, are we expected to update this every year? what does this even mean?
There was a problem hiding this comment.
Yes, I think we are. There are ever github actions for this: https://github.com/marketplace/actions/update-license-copyright-year-s
There was a problem hiding this comment.
I'm not entirely certain about the legal implications of claiming copyright every year, I guess it's related to the expiration of copyright. It seems the correct way is to do a year range (as I did now, ie 2023-2024, which I read as "we claim copyright on all years starting on 2023 and ending at 2024, and that needs to be updated yearly if we add changes)
|
|
||
|
|
||
| class RobotModelArtist(BlenderArtist, RobotModelArtist): | ||
| """Artist for drawing robot models in Blender. | ||
| class RobotModelObject(BlenderSceneObject, BaseRobotModelObject): |
There was a problem hiding this comment.
mmh RobotModelObject sounds a bit too generic to me RobotModelSceneObject too long/verbose?
There was a problem hiding this comment.
I had it like that at first, but the convention in core seems to be XxxObject not XxxSceneObject (eg BoxObject, NetworkObject, etc)
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).