Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/view3d #135

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Feature/view3d #135

wants to merge 7 commits into from

Conversation

PingHsunTsai
Copy link
Collaborator

@PingHsunTsai PingHsunTsai commented May 9, 2024

Propose change

  • change: refactor Render() to View3D
├── view3d() - contain shader() and camera() the components that user can interact
│   ├── InteractiveOpenGLWidget() - contain controller() and selector(), where user can design there key action...(less use)    
│       ├── BaseOpenGLWidget() - contain base QOpenGLWidget       

The goal is to sort the relationship between shader(), camera(), controller() and selector(), at the same time make them more independent from each other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).

@PingHsunTsai PingHsunTsai self-assigned this May 9, 2024
@Licini
Copy link
Collaborator

Licini commented May 9, 2024

Maybe convert to draft if not finished yet?

@PingHsunTsai PingHsunTsai marked this pull request as draft May 9, 2024 08:58
if event.type() == QtCore.QEvent.Gesture:
if event.type() == QtCore.QEvent:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this changed?

@@ -18,7 +18,7 @@ def __init__(self, *args, **kwargs):
self.config = Config()
self.scene = ViewerScene()
# TODO(pitsai): combine config file
self.renderer = Renderer(RendererConfig.from_default())
# self.renderer = Renderer(RendererConfig.from_default())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just delete it?

@tomvanmele
Copy link
Member

shall we maybe close this since it is quite outdated by now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants