Item as kwarg #177
Merged
Item as kwarg #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
reviewed
Jun 13, 2024
| self.objects = [ViewerSceneObject(item, **kwargs) for item in self.collection.items] | ||
| def __init__(self, **kwargs): | ||
| super().__init__(**kwargs) | ||
| kwargs.pop("item") |
There was a problem hiding this comment.
This was to remove item from kwargs so in next line item is not given twice which will trigger error.
There was a problem hiding this comment.
just put item as a keyword argument in the first init
|
@tomvanmele done, take another look? |
tomvanmele
approved these changes
Jun 14, 2024
| def __init__(self, graph: Graph, **kwargs): | ||
| super(GraphObject, self).__init__(graph=graph, **kwargs) | ||
| self.graph: Graph | ||
| """Viewer scene object for displaying COMPAS Graph data.""" |
There was a problem hiding this comment.
why not add the type of graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accommodating the changes from compas-dev/compas#1353