Add static asset build and s3-deploy deploy make task #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballPointPenguin
approved these changes
Nov 14, 2023
|
I'm inclined to place the |
This command does not function as intended, since some assets are compressed, and the `aws s3` command is not actually designed to do anything with the `*.headersJson` files which specify the metadata needed for s3 static site hosting to serve these assets correctly.
This gets around authentication issues with IAM Identity Center users, which require SSO, and aren't well supported by all AWS SDKs.
@ballPointPenguin Interesting idea... Wonder if it wouldn't be better to just have this be an environment variable to configure this? I'm not sure why/when someone would want to do this though, so let's table for now, and fire up another issue if it feels right. |
metasoarous
force-pushed
the
ck/build_and_deploy_makefile
branch
from
65a9540
to
b14105b
Compare
This isn't needed, since we're reverting back to the old script for publishing to s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.