Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring build_interpreter function #31

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

anutosh491
Copy link
Collaborator

No description provided.

@anutosh491
Copy link
Collaborator Author

@vgvassilev I think you started working on introducing clang-tidy. As you're still working on it, should we wait for the CI check to pass before merging anything into master.

@vgvassilev
Copy link
Contributor

No, we should not wait for this.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anutosh491
Copy link
Collaborator Author

No, we should not wait for this.

Thanks. We could merge it then

@anutosh491 anutosh491 merged commit 1c9983b into compiler-research:main Jan 19, 2024
4 of 5 checks passed
@anutosh491 anutosh491 deleted the build_interpreter branch January 19, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants