Skip to content

test: adds negative tests to assemble and regenerate task tests #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

test: adds negative tests to assemble and regenerate task tests #104

merged 1 commit into from
Dec 13, 2023

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Dec 8, 2023 •
edited
Loading

Description

  • Adds tests to test_assemble_task.py and test_regenerate_task.py for failure/negative testing.
  • Add check and test to ensure the markdown directory exists in the assemble task

Stacked/Incorporates #98 in response to PR feedback.

Type of change

  • Adds tests

How has this been tested?

  • Unit tests added

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 changed the title Tests/add negative tests tasks test: adds negative tests to assemble and regenerate task tests Dec 8, 2023
@jpower432 jpower432 mentioned this pull request Dec 8, 2023
Merged
10 tasks
@jpower432
test: adds test to assemble and regenerate tasks for failure testing
f4a66ad 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 force-pushed the tests/add-negative-tests-tasks branch from 93508d6 to f4a66ad Compare December 8, 2023 22:20
@jpower432 jpower432 marked this pull request as ready for review December 8, 2023 23:02
@jpower432
Copy link
Contributor Author

@JimFuller-RedHat PTAL

JimFuller-RedHat
JimFuller-RedHat approved these changes Dec 12, 2023
View reviewed changes
Copy link

@JimFuller-RedHat JimFuller-RedHat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

beatrizmcouto
beatrizmcouto approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test already reviewed by Jim. Discussed during daily on Dec 13

@jpower432 jpower432 merged commit 071d4f0 into complytime:main Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimFuller-RedHat JimFuller-RedHat JimFuller-RedHat approved these changes

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpower432 @JimFuller-RedHat @beatrizmcouto