Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allows no-cache option for image building to ensure updated deps #107

Merged

Conversation

jpower432
Copy link
Contributor

Description

Make the using cache optional when using workflow dispatch and disable the use of it when creating the releases to ensure the we don't experience stale builds or miss out on required updates.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 added ci CI Related work enhancement New feature or request github_actions Pull requests that update GitHub Actions code and removed ci CI Related work labels Dec 8, 2023
@jpower432 jpower432 marked this pull request as draft December 11, 2023 14:56
@jpower432 jpower432 force-pushed the feat/allow-docker-rebuild-option branch from 25963b1 to f3bd23e Compare December 11, 2023 16:29
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 force-pushed the feat/allow-docker-rebuild-option branch from dd8df9f to 18de122 Compare December 11, 2023 17:33
@jpower432 jpower432 marked this pull request as ready for review December 11, 2023 17:44
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during daily December 12

@jpower432 jpower432 merged commit e3b5020 into complytime:main Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants