CPLYTM-224 OSCAL Profiles organized by level task and command (WIP) #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: update README.md emoji placement
|
I saw that many commits are minor incremental updates on the same lines. Considering the number of commits already in this PR, it would be good to squash all these similar minor changes in a single commit to make it easier to review. What do you think? |
|
@marcusburghardt You're absolutely right. I plan on rebasing once the PR is no longer in draft mode. |
…n with CLI feat: updating sync cac content profile task logic feat: updating CLI options for oscal_profile_cmd fix: sync profile task execution update # Conflicts: # trestlebot/cli/commands/sync_cac_content.py # trestlebot/tasks/sync_cac_content_profile_task.py
The initial setup for the interaction of the subcommand interacting with the task. The unit tests included testing for invalid subcommand for the `sync_cac_content_cmd`, and missing required click options from the CLI.
docs: updating docstrings for SyncCacContentProfileTask docs: updating docstrings for SyncCacContentProfileTask
docstrings The updated docstrings will explain the arguments and return types associated with the SyncCacContentProfileTask and the `oscal-profile` sub-command of the `sync-cac-content-cmd`. The unit tests included test for invalid sub-command provided to the `sync_cac_content_cmd`, and missing required click options from the CLI.
|
@hbraswelrh I see another PR #419 for CPLYTM-224, is this one deprecated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
sync_cac_content_profilesub-command will provide users with the ability to indicate the control file for use when authoring OSCAL profiles within trestle-bot. This PR will include a task that interacts directly with the CLI to sort the contents of the control files by level. The level indicated is included in the authored OSCAL profile title and is tailored to the baseline. If there is no level associated with the control file, the task will create a single profile with all controls.Fixes # (issue)
Type of change
How has this been tested?
Test Configuration:
Checklist