bootc: Update revdep test for current bootc main#242
Open
cgwalters wants to merge 2 commits intocomposefs:mainfrom
Open
bootc: Update revdep test for current bootc main#242cgwalters wants to merge 2 commits intocomposefs:mainfrom
cgwalters wants to merge 2 commits intocomposefs:mainfrom
Conversation
Collaborator
Author
|
Hooray, back to having a green bootc revdep test! |
Now that bootc vendors the latest composefs-rs, we can re-sync the CI here to re-test using the bootc tests. Update the patch URL, add cfsctl to the patched crates, and pass the required arguments through to bootc's test-composefs target (defaulting to grub + ext4). Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
I think we were just above 1h before, let's give ourselves some headroom. (obviously it'd be nicer to make this faster) Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
|
Return types were changed in #241, now it breaks again :/ |
Collaborator
Author
|
Yeah this is my bad for changing APIs here, should probably backpressure ourselves a bit on that and add new APIs, deprecating old ones for a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that bootc vendors the latest composefs-rs, we can re-sync the CI here to re-test using the bootc tests.
Update the patch URL, add cfsctl to the patched crates, and pass the required arguments through to bootc's test-composefs target (defaulting to grub + ext4).
Assisted-by: OpenCode (Claude claude-opus-4-6)