Skip to content

Json parser #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Json parser #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0c97d09
wip.
Apr 27, 2020
9a11a99
Fix bug in parseJsonObject.
May 5, 2020
3b2b902
Add foldUtf8With to decodeUtf8 to containers.
May 5, 2020
f87a801
Use simpler implementations instead of alts and inline
May 5, 2020
c999683
Add sepBy parser combinator.
May 7, 2020
52965a0
Use custom sepBy in Json stream.
May 7, 2020
53de122
die instead of error
May 8, 2020
33bfb5f
die in more instances.
May 11, 2020
f58dc2d
WIP.
Jul 15, 2020
0242b0a
Add benchmark for parseJson.
Jul 17, 2020
5c74afd
Properly escape characters in JSON strings.
Aug 3, 2020
e38339a
fixup.
Sep 16, 2020
284740a
Use ParserK instead of ParserD.
Oct 29, 2020
4db99a8
Make a custom implementation of parseJsonString.
Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion benchmark/Streamly/Benchmark/FileSystem/Handle/Read.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ module Handle.Read
(allBenchmarks)
where

import Control.Monad (void)
import Data.Char (ord)
import Data.Functor.Identity (runIdentity)
import Data.Word (Word8)
Expand All @@ -32,11 +33,12 @@ import GHC.Magic (noinline)
#else
#define noinline
#endif
import System.IO (Handle)
import System.IO (Handle, hClose, openFile, IOMode(..))
import Prelude hiding (last, length)

import qualified Streamly.Data.Fold as FL
import qualified Streamly.Unicode.Stream as SS
import qualified Streamly.Internal.Data.Json.Stream as SJ
import qualified Streamly.FileSystem.Handle as FH
-- import qualified Streamly.Internal.Data.Fold as IFL
import qualified Streamly.Internal.Data.Parser as PR
Expand Down Expand Up @@ -246,6 +248,24 @@ readDecodeUtf8 inh =
$ SS.decodeUtf8
$ S.unfold FH.read inh

readJsonDrain :: Handle -> IO ()
readJsonDrain inh =
void
$ IP.parse SJ.parseJson
$ S.unfold FH.read inh

o_n_space_parse_json :: [Benchmark]
o_n_space_parse_json =
[ bgroup
"parse/json"
[ bench "parseJson" $
nfIO $ do
inh <- openFile "twitter.json" ReadMode
readJsonDrain inh
hClose inh
]
]

#ifdef INSPECTION
inspect $ hasNoTypeClasses 'readDecodeUtf8
-- inspect $ 'readDecodeUtf8Lax `hasNoType` ''Step
Expand Down Expand Up @@ -531,4 +551,5 @@ allBenchmarks env = Prelude.concat
, o_1_space_reduce_read_grouped env
, o_1_space_reduce_read_split env
, o_1_space_reduce_toChunks_split env
, o_n_space_parse_json
]
Loading