Enhance GC in events.

compositejs · Sep 12, 2024 · caedd52 · caedd52
1 parent 2771a8d
commit caedd52
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "datasense",
-  "version": "2.2.0",
+  "version": "2.3.0",
   "description": "A set of powerful utilities and classes for accessing and observing data.",
   "main": "index.js",
   "types": "./index.d.ts",

diff --git a/src/events.ts b/src/events.ts
@@ -595,6 +595,7 @@ export class EventObservable implements DisposableArrayContract {
         };
         let implInstance = this._instance;
         implInstance.push(key, obj);
+        let disposableResult: DisposableContract = {} as any;
         let result: EventRegisterResultContract<T> = {
             get key() {
                 return key;
@@ -617,10 +618,16 @@ export class EventObservable implements DisposableArrayContract {
             dispose() {
                 implInstance.remove(key, obj);
                 disposableList.dispose();
+                disposableResult.dispose = () => { };
             }
         };
-        implInstance.pushDisposable(result);
-        if (disposableArray) disposableArray.pushDisposable(result);
+        disposableResult.dispose = () =>
+        {
+            result.dispose();
+            disposableResult.dispose = () => { };
+        };
+        implInstance.pushDisposable(disposableResult);
+        if (disposableArray) disposableArray.pushDisposable(disposableResult);
         return result;
     }