Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Compound III USDC market on Optimism #838

Conversation

dmitriy-woof-software
Copy link
Contributor

@dmitriy-woof-software dmitriy-woof-software commented Mar 23, 2024

This PR introduces the deployment for the USDC market on the Optimism network as well as the proposal to initialize the market there.

Forum thread - https://www.comp.xyz/t/deploy-compound-iii-on-optimism/4975

Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this so far! Left some comments.

hardhat.config.ts Outdated Show resolved Hide resolved
plugins/deployment_manager/test/ImportTest.ts Outdated Show resolved Hide resolved
src/deploy/index.ts Outdated Show resolved Hide resolved
src/deploy/index.ts Outdated Show resolved Hide resolved
deployments/optimism/usdc/configuration.json Show resolved Hide resolved
deployments/optimism/usdc/configuration.json Outdated Show resolved Hide resolved
},
"wstETH": {
"address": "0x1F32b1c2345538c0c6f582fCB022739c4A194Ebb",
"priceFeed": "0x698B585CbC4407e2D54aa898B2600B53C68958f7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the market-based wstETH / USD price feed. Lido's recent proposals to list wstETH seem to go with the exchange-rate-based wstETH / stETH * ETH / USD custom price feed. Let's maybe wait for them to finalize on that decision and make the same decision here to be consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear. Could we not wait for Lido's decision?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you suggested, you could just exclude wstETH for now until that decision has been made.

plugins/import/import.ts Outdated Show resolved Hide resolved
scenario/BulkerScenario.ts Outdated Show resolved Hide resolved
…assets order; add regexDoubleQuotes match to scrapeContractCreationCodeFromEtherscan function; start executing Comet#bulker > (non-WETH base) scenario; update testnet COMP whale; update optimism mainnet whales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants