Skip to content

Commit

Permalink
fix: add read-only access to github user profile data
Browse files Browse the repository at this point in the history
github new user flow appears to work now but needs additional testing
from others
  • Loading branch information
alee committed Jul 16, 2024
1 parent 621b7b8 commit 177cc99
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion django/core/settings/defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def is_test(self):
"allauth.account",
"allauth.socialaccount",
"allauth.socialaccount.providers.github",
"allauth.socialaccount.providers.google",
"allauth.socialaccount.providers.orcid",
]

Expand Down Expand Up @@ -505,9 +506,11 @@ def is_test(self):
# https://developer.github.com/apps/building-integrations/setting-up-and-registering-oauth-apps/about-scopes-for-oauth-apps/
"github": {
"SCOPE": [
"read:user",
"user:email",
"read:org",
],
# "VERIFIED_EMAIL": True,
},
# http://django-allauth.readthedocs.io/en/latest/providers.html#orcid
# NOTE: must be deleted in production settings
Expand All @@ -517,7 +520,6 @@ def is_test(self):
},
}


DISCOURSE_BASE_URL = os.getenv(
"DISCOURSE_BASE_URL", "https://staging-discourse.comses.net"
)
Expand Down

1 comment on commit 177cc99

@sgfost
Copy link
Contributor

@sgfost sgfost commented on 177cc99 Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to do the trick, though I can't quite tell why

Please sign in to comment.