-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add conan run command to run packages from Conan directly
#18972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--------- Co-authored-by: PerseoGI <perseog@jfrog.com>
conan run command to run commands from previous conan install runsconan run command to run packages from Conan directly
73b2e7a to
8d204f7
Compare
… ar/conan-run-command
memsharded
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still concerned about the output modifications
conan/internal/model/conan_file.py
Outdated
| ConanOutput().writeln(f"{self.display_name}: RUN: {command}", fg=Color.BRIGHT_BLUE) | ||
| ConanOutput().info(f"{self.display_name}: RUN: {command}", fg=Color.BRIGHT_BLUE) | ||
| ConanOutput().debug(f"{self.display_name}: Full command: {wrapped_cmd}") | ||
| if quiet or ConanOutput()._conan_output_level == LEVEL_QUIET: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the fact that changes to how Conan outputs things are being done for the new conan run experimental functionality. I think these changes are riskier than they appear, and should be avoided, or at least considered more carefully.
memsharded
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, but I think there are still a couple of points to discuss and check
Changelog: Feature: Add
conan runcommand to run commands from packagesChangelog: Bugfix:
Conanfile.run'squietparameter now silences the output of the commandChangelog: Bugfix: Verbosity level
quietnow also silences the output of tools ran by ConanDocs: conan-io/docs#4327
The idea is that users have an easy way to execute binaries from their dependencies (or their package when using
--requires) without the need to first activate the conan-generated environments