Skip to content

Conversation

@AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Sep 29, 2025

Changelog: Fix: Improve support for huge diffs in conan report diff HTML output
Docs: conan-io/docs#4279

My weekend project of learning about the Intersection Observer API

Still needs some tests, but this works great locally for big diffs that prior to this would struggle to work properly.

There is an issue with upwards scrolling unloaded content, but other than that, this looks almost ready

AbrilRBS and others added 2 commits September 29, 2025 17:05
---------

Co-authored-by: Ernesto de Gracia Herranz <ernestodgh@jfrog.com>
@AbrilRBS AbrilRBS added this to the 2.22.0 milestone Sep 29, 2025
@AbrilRBS AbrilRBS requested a review from ErniGH October 6, 2025 08:47
@AbrilRBS AbrilRBS marked this pull request as ready for review October 6, 2025 23:21
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with really huge diff files and I can confirm it works great.

Thank you, @AbrilRBS, for the big improvement!

Screen.Recording.2025-10-22.at.11.09.04.mov

@memsharded memsharded self-assigned this Oct 22, 2025
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The difference is very noticeable with large diffs. These diffs for libraries with many changes between versions can reach up to 600,000 lines of code in the HTML, and this report diff manages to render the changes.

@memsharded memsharded merged commit beb5cb6 into conan-io:develop2 Oct 22, 2025
16 checks passed
@AbrilRBS AbrilRBS deleted the ar/report-diff-huge-diffs-fix branch October 22, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants