-
Couldn't load subscription status.
- Fork 1.1k
Improve performance for huge diffs in conan report diff HTML output
#19012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance for huge diffs in conan report diff HTML output
#19012
Conversation
--------- Co-authored-by: Ernesto de Gracia Herranz <ernestodgh@jfrog.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with really huge diff files and I can confirm it works great.
Thank you, @AbrilRBS, for the big improvement!
Screen.Recording.2025-10-22.at.11.09.04.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The difference is very noticeable with large diffs. These diffs for libraries with many changes between versions can reach up to 600,000 lines of code in the HTML, and this report diff manages to render the changes.
Changelog: Fix: Improve support for huge diffs in
conan report diffHTML outputDocs: conan-io/docs#4279
My weekend project of learning about the
Intersection Observer APIStill needs some tests, but this works great locally for big diffs that prior to this would struggle to work properly.
There is an issue with upwards scrolling unloaded content, but other than that, this looks almost ready