Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

188577538 Make Selected Dots the Same Size as Unselected Dots #1664

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tealefristoe
Copy link
Contributor

@tealefristoe tealefristoe commented Dec 3, 2024

PT Story: https://www.pivotaltracker.com/story/show/188577538

This PR makes selected dots the same size as unselected dots in graphs. Note that this behavior differs from v2, so it will probably not be merged.

@tealefristoe tealefristoe marked this pull request as draft December 3, 2024 16:43
@tealefristoe tealefristoe added the v3 CODAP v3 label Dec 3, 2024
Copy link

cypress bot commented Dec 3, 2024

codap-v3    Run #5428

Run Properties:  status check passed Passed #5428  •  git commit b060bb6a83: Make selected dots the same size as unselected dots.
Project codap-v3
Branch Review 188577538-v3-selected-point-size
Run status status check passed Passed #5428
Run duration 01m 55s
Commit git commit b060bb6a83: Make selected dots the same size as unselected dots.
Committer Teale Fristoe
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.02%. Comparing base (dc907ff) to head (b060bb6).
Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (dc907ff) and HEAD (b060bb6). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (dc907ff) HEAD (b060bb6)
cypress 10 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1664       +/-   ##
===========================================
- Coverage   85.81%   68.02%   -17.80%     
===========================================
  Files         604      604               
  Lines       30758    30758               
  Branches     7906     8493      +587     
===========================================
- Hits        26395    20922     -5473     
- Misses       4208     9681     +5473     
  Partials      155      155               
Flag Coverage Δ
cypress 43.86% <100.00%> (-31.50%) ⬇️
jest 53.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CODAP v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant