-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eventModification debug flag #1811
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
+ Coverage 85.95% 85.99% +0.04%
==========================================
Files 636 637 +1
Lines 32739 32757 +18
Branches 8572 9203 +631
==========================================
+ Hits 28140 28170 +30
+ Misses 4443 4255 -188
- Partials 156 332 +176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codap-v3
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
|
Run duration | 06m 27s |
Commit |
|
Committer | Scott Cytacki |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
51
|
|
0
|
|
245
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good -- I suggest adding releasePointerCapture
to the events tracked.
] as const | ||
|
||
const elementMethods = [ | ||
"setPointerCapture" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"setPointerCapture" | |
"setPointerCapture", | |
"releasePointerCapture" |
I think it would be useful to track both to make it clear whether the capture was released or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it, but I'd also note that it isn't necessary to call releasePointerCapture
. According to https://developer.mozilla.org/en-US/docs/Web/API/Element/setPointerCapture the capture will be released automatically when the pointerup
event is fired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know.
No description provided.