Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eventModification debug flag #1811

Merged
merged 2 commits into from
Mar 12, 2025
Merged

add eventModification debug flag #1811

merged 2 commits into from
Mar 12, 2025

Conversation

scytacki
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (3eb9c48) to head (9103bdd).
Report is 129 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/lib/debug-event-modification.ts 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
+ Coverage   85.95%   85.99%   +0.04%     
==========================================
  Files         636      637       +1     
  Lines       32739    32757      +18     
  Branches     8572     9203     +631     
==========================================
+ Hits        28140    28170      +30     
+ Misses       4443     4255     -188     
- Partials      156      332     +176     
Flag Coverage Δ
cypress 73.36% <25.00%> (+0.06%) ⬆️
jest 55.29% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Feb 13, 2025

codap-v3    Run #6569

Run Properties:  status check passed Passed #6569  •  git commit 717841b0da: Merge pull request #1811 from concord-consortium/debug-event-modification
Project codap-v3
Branch Review main
Run status status check passed Passed #6569
Run duration 06m 27s
Commit git commit 717841b0da: Merge pull request #1811 from concord-consortium/debug-event-modification
Committer Scott Cytacki
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 51
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 245
View all changes introduced in this branch ↗︎

@scytacki scytacki marked this pull request as ready for review February 14, 2025 14:44
@scytacki scytacki requested a review from kswenson February 25, 2025 18:25
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good -- I suggest adding releasePointerCapture to the events tracked.

] as const

const elementMethods = [
"setPointerCapture"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"setPointerCapture"
"setPointerCapture",
"releasePointerCapture"

I think it would be useful to track both to make it clear whether the capture was released or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it, but I'd also note that it isn't necessary to call releasePointerCapture. According to https://developer.mozilla.org/en-US/docs/Web/API/Element/setPointerCapture the capture will be released automatically when the pointerup event is fired.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know.

@scytacki scytacki merged commit 717841b into main Mar 12, 2025
19 of 21 checks passed
@scytacki scytacki deleted the debug-event-modification branch March 12, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants