Fixes table display bug when collection has one attribute and it is hidden #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idden. Fix is by showing the hidden attribute.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
==========================================
+ Coverage 85.51% 86.13% +0.62%
==========================================
Files 649 649
Lines 33276 33287 +11
Branches 9293 8770 -523
==========================================
+ Hits 28455 28671 +216
+ Misses 4463 4458 -5
+ Partials 358 158 -200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 06m 43s |
| Commit |
|
| Committer | Evangeline Ireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
51
|
Skipped
|
0
|
Passing
|
245
|
| View all changes introduced in this branch ↗︎ | |
kswenson
requested changes
Mar 7, 2025
Comment on lines
36
to
39
| // if attribute is the only attribute in the collection and it is hidden, make the attribute visible | ||
| if (attrs.length === 1 && caseMetadata?.isHidden(attrs[0].id)) { | ||
| caseMetadata?.setIsHidden(attrs[0].id, false) | ||
| } |
There was a problem hiding this comment.
Couple of issues:
- The case table is not the right place to address an issue that doesn't require the case table. (Attributes can be hidden from other components, e.g. the case card.)
- The accessor function of a reaction is just for returning values to the action function, not for actually changing models.
- The number of attributes isn't important. The relevant test is whether all remaining attributes in a collection are hidden, in which case they should all be shown.
I suspect that a reaction that is installed in the afterCreate() of the SharedCaseMetadata would make the most sense.
…ttributes as a reaction in the SharedCaseMetadata model
kswenson
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is by showing the hidden attribute, which automatically makes copllection visible.