Merge pull request #1108 from concord-consortium/fix-glossary-edit-link

fix: user.project_admin_of? with nil project
concord-consortium · Dec 6, 2023 · cd33614 · cd33614
2 parents fd12ef3 + e8d6c4c
commit cd33614
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/models/user.rb b/app/models/user.rb
@@ -50,7 +50,7 @@ def is_project_admin?()
   end
 
   def project_admin_of?(project)
-    project && admined_projects.any? {|ap| ap.id == project.id }
+    !!(project && admined_projects.any? {|ap| ap.id == project.id })
   end
 
   def most_recent_authentication

diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
@@ -514,6 +514,7 @@
       expect(user.project_admins.length).to be(0)
       expect(user.admined_projects.length).to be(0)
 
+      expect(user.project_admin_of?(nil)).to be(false)
       expect(user.project_admin_of?(project1)).to be(false)
       expect(user.project_admin_of?(project2)).to be(false)
     end