Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added /lara-cypress-tests/ to /lara/ #1211

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

nstclair-cc
Copy link
Contributor

@nstclair-cc nstclair-cc commented Jan 22, 2025

PT-188805042

This PR is still in draft mode, but I’m reaching out for help on a few open issues.

Summary

This work integrates the /lara-cypress-tests/ into the /lara/ repository. The changes include:
• Migrating scripts from /lara-cypress/tests/cypress/ to /lara/cypress/.
• Adding an initial draft of GitHub Actions to run Cypress integration tests on code pushes.
• Updating README.md to include details about the Cypress automation tests.

I’ve tested a few scripts locally, and they’re working fine in production mode (I need to test in production mode because my machine is an M1 chip). The next step will be setting up CI for Cypress tests on GitHub.

To-Dos

  • Get Cypress integration actions working on GitHub (this may require a separate story).
  • Ensure package.json and package-lock.json are correctly updated to reflect the Cypress changes.
  • Decide whether to clean up dead code in /lara-cypress-tests/ or keep the repository open with these changes.
  • Decide whether to include LARA JSON files in /cypress/

@nstclair-cc nstclair-cc self-assigned this Jan 23, 2025
@nstclair-cc nstclair-cc marked this pull request as ready for review January 28, 2025 20:32
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks the the cypress: label needs to be indented in the ci.yml file so that it is under the jobs: section on the same column as build:. That is why the Cypress tests aren't running for this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants