-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added /lara-cypress-tests/ to /lara/ #1211
Open
nstclair-cc
wants to merge
31
commits into
master
Choose a base branch
from
188805042-move-lara-cypress-tests-to-lara
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougmartin
reviewed
Jan 24, 2025
dougmartin
reviewed
Jan 24, 2025
dougmartin
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks the the cypress:
label needs to be indented in the ci.yml
file so that it is under the jobs:
section on the same column as build:
. That is why the Cypress tests aren't running for this branch.
This is needed as we have an older node version baked into the build system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT-188805042
This PR is still in draft mode, but I’m reaching out for help on a few open issues.
Summary
This work integrates the
/lara-cypress-tests/
into the/lara/
repository. The changes include:• Migrating scripts from
/lara-cypress/tests/cypress/
to/lara/cypress/
.• Adding an initial draft of GitHub Actions to run Cypress integration tests on code pushes.
• Updating
README.md
to include details about the Cypress automation tests.I’ve tested a few scripts locally, and they’re working fine in production mode (I need to test in production mode because my machine is an M1 chip). The next step will be setting up CI for Cypress tests on GitHub.
To-Dos
package.json
andpackage-lock.json
are correctly updated to reflect the Cypress changes./lara-cypress-tests/
or keep the repository open with these changes./cypress/