Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for JS error: "TypeError: h$concur is undefined" #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

demaledetti
Copy link

These changes are inspired by package.json and webpack.config.js from https://github.com/concurhaskell/concur-react-starter ( eefa5d5 ) and their goal is to avoid a run-time JS error (TypeError: h$concur is undefined) that prevents the SortableTree component from displaying at all.

I am a webpack newbie so I might be very wrong but in my understanding these changes seem to contradict the advice given here:

https://github.com/concurhaskell/concur-react-starter#important-note-you-dont-need-to-add-react-and-reactdom-in-packagejson-as-those-dependencies-will-be-pulled-from-concur-react

"IMPORTANT NOTE: You don't need to add React and ReactDOM in package.json, as those dependencies will be pulled from Concur-React."

With these changes, the JS error doesn't happen and the SortableTree is displayed and works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant