Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for aws_sdk_cpp #3593

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for aws_sdk_cpp. The current pinned version is 1.9.160, the latest available version is 1.9.372 and the max pin pattern is x.x.x. This migration will impact 1 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 1.9.160 to 1.9.372.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping aws-sdk-cpp
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3333670095, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner October 27, 2022 02:47
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/aws-sdk-cpp and so here I am doing that.

@h-vetinari
Copy link
Member

@xhochy, can I ask why do you close all the migrator PRs for aws-sdk-cpp? Is it because arrow-cpp is still on 1.8 (so we don't move the rest of the ecosystem out of sync)?

I just tried a default rerender for aws 1.9.*, which gives 1.9.160 according to the pinning, whereas the feedstock is at 1.9.372 (!) now.

@h-vetinari
Copy link
Member

@xhochy
Copy link
Member

xhochy commented Oct 27, 2022

I'm closing all these as I was under the impression that arrow-cpp is the only consumer (seems that we also have https://github.com/conda-forge/torchdata-feedstock/blob/main/recipe/meta.yaml) and that the upstream issue aws/aws-sdk-cpp#1809 hasn't been fixed and showed up in other artifacts, too. I would like to know that that issue has been fixed and only would then start a migrator. As there are near to daily releases of aws-sdk-cpp, a new migrator will show up quite quickly.

@h-vetinari
Copy link
Member

I would like to know that that issue has been fixed and only would then start a migrator.

I added the supposed reproducer as a test in conda-forge/arrow-cpp-feedstock#880, and it seems to pass with the newest aws-sdk-cpp (interestingly, that's without the supposed fix for aws/aws-sdk-cpp#1809 which landed in aws-c-io 0.3.15, which hasn't made its way to aws-sdk-cpp yet.

Are there other previous reproducers we can test (maybe just try the test on an old 1.9.x)?

@h-vetinari
Copy link
Member

I added the supposed reproducer as a test in conda-forge/arrow-cpp-feedstock#880, and it seems to pass with the newest aws-sdk-cpp

Just realised that the reproducer probably needs to be run on AWS to appear? At least I don't see why/how the code would trigger any code paths concerning aws-sdk-cpp

@xhochy
Copy link
Member

xhochy commented Oct 27, 2022

Are there other previous reproducers we can test (maybe just try the test on an old 1.9.x)?

I was never able to reproduce it. This made it hard for myself to investigate.

@xhochy xhochy closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants