Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for aws_sdk_cpp #3631

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for aws_sdk_cpp. The current pinned version is 1.9.160, the latest available version is 1.9.375 and the max pin pattern is x.x.x. This migration will impact 1 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 1.9.160 to 1.9.375.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping aws-sdk-cpp
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3370313844, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner November 1, 2022 16:47
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/aws-sdk-cpp and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

@xhochy @conda-forge/arrow-cpp
I actually think we should try to remove the pin on aws-sdk-cpp 1.8 now, at least for arrow 10.0.0. The FATAL_ASSERT causing aws/aws-sdk-cpp#1809 was removed in aws-c-io 0.3.15, and that migration has now closed on our side.

My idea would be to rebuild arrow 10.0.0 with this, and ask for early adopters to try if the issue persists. If not, great (and we can backport to the other ABI branches), if yes, we mark the builds as broken.

PS. Obviously I don't need the migrator to do that (as there's only one dependent feedstock), but since the rest of the aws-stack has continued migrating, and aws-sdk-cpp 1.8.x isn't buildable against that anymore, we'll have to bite that bullet at some point anyway. With the FATAL_ASSERT removed, I actually have pretty high confidence that things should be fine.

@xhochy
Copy link
Member

xhochy commented Nov 2, 2022

@h-vetinari If you're happy to do the repodata-patches/mark-broken afterwards if it fails: Let's go for it!

@xhochy
Copy link
Member

xhochy commented Nov 2, 2022

Should I merge this then?

@h-vetinari
Copy link
Member

h-vetinari commented Nov 2, 2022

@h-vetinari If you're happy to do the repodata-patches/mark-broken afterwards if it fails: Let's go for it!

Fine by me.

Should I merge this then?

It's not so urgent, because the PR for arrow 10 is still waiting for some infra work. There's also two three migrators in the wings:

But generally I'd say we're ready (as these new versions don't seem to stop coming 😅). It only affects arrow anyway, so if we merge now then I could plonk the migrator into arrow 10.

@xhochy xhochy merged commit b04ceee into conda-forge:main Nov 3, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the new_pin-aws_sdk_cpp-1.9.375-0-_h33525f branch November 3, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants