actually close aws_sdk_cpp 1.9.x migration #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3735 should not have been merged yet, all the maintenance branches in arrow were still open (until conda-forge/arrow-cpp-feedstock#918 was closed today).
Also, I've been using
1.9.379for all those builds, because that's the last release in the 1.9.x series which has a migration branch that keeps it up-to-date w.r.t. to all the other aws-* migrations.Bumping directly is fine because arrow is the only consumer, and all maintenance branches use 1.9.379.
CC @conda-forge/aws-sdk-cpp @ocefpaf
PS. It would be nice to have the ABI branches be taken into account for the bot (and show up on the status page...)