Add a patch to pin openblas <0.3.26 for older scipy builds #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
I think the approach is correct, but this is touching a lot of builds (even though the addition of a constraint for a package that didn't exist at the time these builds were published should be pretty harmless). Not sure what the best way to handle this is. CC @conda-forge/core. |
h-vetinari
approved these changes
Jan 24, 2024
recipe/patch_yaml/scipy.yaml
Outdated
| @@ -0,0 +1,26 @@ | |||
| # 2024/01 -- hmaarrfk | |||
| # scipy version 1.20.0 build 2 was patched | |||
There was a problem hiding this comment.
Suggested change
| # scipy version 1.20.0 build 2 was patched | |
| # scipy version 1.12.0 build 2 was patched |
recipe/patch_yaml/scipy.yaml
Outdated
| --- | ||
|
|
||
| # 2024/01 -- hmaarrfk | ||
| # scipy version 1.20.0 build 2 was patched |
There was a problem hiding this comment.
Suggested change
| # scipy version 1.20.0 build 2 was patched | |
| # scipy version 1.12.0 build 2 was patched |
hmaarrfk
force-pushed
the
scipy_libopenblas
branch
from
fd95c89 to
ac954e7
Compare
|
Any comments? This is hitting scipy installs quite widely so I think we should do it (e.g. someone who's not able to update to 1.12, which is the only version that's fixed ATM) |
|
merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: conda-forge/scipy-feedstock#266 (comment)
cc: @h-vetinari
diff: https://gist.github.com/hmaarrfk/b69c7844166efc7cd61f98ae2a4548d5
Checklist
generate_patch_json.pyif absolutely necessary.pre-commit run -aand ensured all files pass the linting checks.python show_diff.pyand posted the output as part of the PR.