Skip to content

Commit

Permalink
Update docs
Browse files Browse the repository at this point in the history
  • Loading branch information
chloefeal committed Feb 2, 2025
1 parent 7104f77 commit 62d83bb
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/maintainer/adding_pkgs.md
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ package works correctly. In particular, it doesn't test if it works
correctly with the versions of dependencies used. In some cases, the top level
import name does not contain any executable code (e.g. a package with an empty
`__init__.py`, or without any direct imports). This test would always pass!
In these cases, it helps to add more imports explicitly targetting modules
In these cases, it helps to add more imports explicitly targeting modules
that do contain executable code (e.g. `package_name.core`).

It is good to run some other tests of the code itself (the test suite) if possible.
Expand Down
2 changes: 1 addition & 1 deletion docs/maintainer/infrastructure.md
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ work and learn about some of the historical context of the feedstock.
Once you have established a working relationship with the maintainers, you can ask
them to add you to the feedstock team. They can then use this command
to add you to the team. There isn't any official requirement for how to add new
maintainers so it may take a while for concensus to be reached
maintainers so it may take a while for consensus to be reached
on when to add new maintainers. Do not let this discourage you from contributing!

PRs are free to be opened by anyone!!! Thank you for your time and effort!!!
Expand Down
2 changes: 1 addition & 1 deletion docs/maintainer/knowledge_base.md
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,7 @@ Before learning how to use it, please read these considerations:

- Adding microarchitecture variants can result in too many entries in the build matrix. Do not overuse it.
- These optimized builds should only be used when the performance improvements are significant.
- Preferrably, the project should rely on runtime dispatch for arch-specific optimizations.
- Preferably, the project should rely on runtime dispatch for arch-specific optimizations.
- If the package is already too large, consider using smaller outputs for the arch-optimized variants.

To implement microarchitecture-optimized builds in your feedstock, you'll end up with something like:
Expand Down
2 changes: 1 addition & 1 deletion docs/maintainer/maintainer_faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ There is no need to approve the PR. Every maintainer can verify and merge the bo

## How to fix "build-locally.py fails with exit code 139"?

With Linux Kernel 4.11 there were some changes in the `vsyscall` linking. Depending on your distribution this may cause the above error. You can fix that on Debian by editing `/etc/default/grub` and specifiy `GRUB_CMDLINE_LINUX_DEFAULT="vsyscall=emulate"` in this file. Afterwards, you need to run `update-grub` and reboot your system. On other Linux distributions the fix is similar but you need to edit a different configuration file to change the Linux kernel cmdline. This workaround is only needed for images based on CentOS 6 (`cos6`). You could also workaround this by forcing the CentOS 7 based images using `DOCKER_IMAGE=quay.io/condaforge/linux-anvil-cos7-x86_64 ./build-locally.py`.
With Linux Kernel 4.11 there were some changes in the `vsyscall` linking. Depending on your distribution this may cause the above error. You can fix that on Debian by editing `/etc/default/grub` and specify `GRUB_CMDLINE_LINUX_DEFAULT="vsyscall=emulate"` in this file. Afterwards, you need to run `update-grub` and reboot your system. On other Linux distributions the fix is similar but you need to edit a different configuration file to change the Linux kernel cmdline. This workaround is only needed for images based on CentOS 6 (`cos6`). You could also workaround this by forcing the CentOS 7 based images using `DOCKER_IMAGE=quay.io/condaforge/linux-anvil-cos7-x86_64 ./build-locally.py`.

The exit code 139 itself actually is the general exit code for a segmentation fault. This could also mean that you have run into a different issue but the above issue is the most likely one with our CentOS 6-based images.

Expand Down
2 changes: 1 addition & 1 deletion docs/maintainer/updating_pkgs.md
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ work and learn about some of the historical context of the feedstock.
Once you have established a working relationship with the maintainers, you can ask
them to add you to the feedstock team. They can then use this command
to add you to the team. There isn't any official requirement for how to add new
maintainers so it may take a while for concensus to be reached
maintainers so it may take a while for consensus to be reached
on when to add new maintainers. Do not let this discourage you from contributing!

PRs are free to be opened by anyone!!! Thank you for your time and effort!!!
Expand Down

0 comments on commit 62d83bb

Please sign in to comment.