Skip to content

Commit

Permalink
Merge pull request #1960 from vepadulano/yum-fix-ulimit
Browse files Browse the repository at this point in the history
  • Loading branch information
beckermr authored Jun 24, 2024
2 parents 9ff0aa2 + fb81f23 commit 9e4720f
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 1 deletion.
9 changes: 8 additions & 1 deletion conda_smithy/templates/build_steps.sh.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,14 @@ setup_conda_rc "${FEEDSTOCK_ROOT}" "${RECIPE_ROOT}" "${CONFIG_FILE}"
{% if build_setup -%}
{{ build_setup }}{% endif -%}
{% if yum_build_setup is defined -%}
{{ yum_build_setup }}{% endif -%}
(
# Due to https://bugzilla.redhat.com/show_bug.cgi?id=1537564 old versions of rpm
# are drastically slowed down when the number of file descriptors is very high.
# This can be visible during a `yum install` step of a feedstock build.
# => Set a lower limit in a subshell for the `yum install`s only.
ulimit -n 1024
{{ yum_build_setup }}
){% endif -%}

# make the build number clobber
make_build_number "${FEEDSTOCK_ROOT}" "${RECIPE_ROOT}" "${CONFIG_FILE}"
Expand Down
26 changes: 26 additions & 0 deletions news/1958_yum_fix_ulimit.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
**Added:**

* <news item>

**Changed:**

* Changed the build_steps.sh template so that it sets the number of maximum file
descriptors to 1024. This is done to mitigate a bug in old rpm versions (such
as the one shipped with the Centos7 container) that cause the yum install step
to take tremendously longer than necessary. See https://bugzilla.redhat.com/show_bug.cgi?id=1537564

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* <news item>

**Security:**

* <news item>

0 comments on commit 9e4720f

Please sign in to comment.