Unify Windows batch logic #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimergp
added a commit
to jaimergp/dav1d-feedstock
that referenced
this pull request
Sep 6, 2023
jaimergp
added a commit
to jaimergp-feedstocks/dav1d-feedstock
that referenced
this pull request
Sep 6, 2023
1 task
jaimergp
commented
Sep 6, 2023
| @@ -941,7 +941,7 @@ def _get_build_setup_line(forge_dir, platform, forge_config): | |||
| if platform == "win": | |||
| build_setup += textwrap.dedent( | |||
| """\ | |||
| run_conda_forge_build_setup | |||
| CALL run_conda_forge_build_setup | |||
There was a problem hiding this comment.
Without using CALL, this batch script coming from conda-forge-ci-setup might (will?) exit early with errorlevel = 0, misreporting success without even running the recipe.
|
@conda-forge/core - ready for review! |
beckermr
approved these changes
Sep 6, 2023
This was referenced Sep 7, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentryWe had duplicate logic for Azure and Github Actions, which was resulting in duplicated efforts in PRs like #1732, and divergence of features/bugfixes (GHA didn't have
python=3.10,UPLOAD_ON_BRANCHor the%TEMP%fixes foranaconda upload ...).In this PR I am hoping to unify both in a single script, which should also get us closer to having
build-locally.pyfeatures for Windows. The downside is that the Azure build steps will be now a single one, which is not terrible and can be worked with logging groups like we do in Unix if needed.One thing to pay special attention to is the error handling on CMD. It can be terribly confusing depending on too many edge cases (see #1704, I will probably restart work on that after this one lands).
Tests:
maindav1d-feedstock#10