Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: rerender #13

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

MNT: rerender #13

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
098c3c7
dummy commit for rerendering
conda-forge-webservices[bot] Aug 2, 2024
b1df738
Add empty `platform` for `osx`
jakirkham Aug 2, 2024
a6e6501
MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.37.2, and co…
Aug 2, 2024
42c430c
Set `platform` fallback value
jakirkham Aug 2, 2024
e433191
Revert "Set `platform` fallback value"
jakirkham Aug 3, 2024
086d6f2
Limit URL to cases where `platform` is defined
jakirkham Aug 3, 2024
9298d7c
Revert "Add empty `platform` for `osx`"
jakirkham Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ package:
version: {{ version }}

source:
url: https://developer.download.nvidia.com/compute/cuda/redist/cuda_nvdisasm/{{ platform }}/cuda_nvdisasm-{{ platform }}-{{ version }}-archive.{{ extension }}
url: https://developer.download.nvidia.com/compute/cuda/redist/cuda_nvdisasm/{{ platform }}/cuda_nvdisasm-{{ platform }}-{{ version }}-archive.{{ extension }} # [linux64 or ppc64le or aarch64 or win]
Copy link
Member

@jakirkham jakirkham Aug 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this is the core of the issue. The re-rendering process does not like that platform is undefined in some cases (even for skipped platforms)

With conda-build version 24.5, this was not an issue

However in conda-build version 24.7, this is now an issue

Still need to dig further to understand what changed to cause this issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have described this in more detail in issue: conda-forge/conda-smithy#2011

sha256: ba60cc8c9cfabb399b70aa49ee3428f7c489330b0aa7c8616121651e56dacc3e # [linux64]
sha256: 7ed318e59165e4d838df65618042b139f7743b80c22f3f28764287732503f52b # [aarch64]
sha256: 9ac787efbcd20c4c871038ee5ca1c0757139990b25ea90d368aa9c1759952be6 # [win]
Expand Down