Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable linux_aarch64 build platform #8

Merged
merged 11 commits into from
May 11, 2024
Merged

feat: Enable linux_aarch64 build platform #8

merged 11 commits into from
May 11, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 10, 2024 •
edited
Loading

Attempt PR #2 again.

linux_ppc64le seems to be unsupported now: #8 (comment)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.
* Enable linux_aarch64 build platform by adding provider key.
   - c.f. https://conda-forge.org/docs/maintainer/conda_forge_yml/#provider
* Bump the build number.
* MNT: Re-rendered with conda-build 24.3.0, conda-smithy 3.35.1, and
  conda-forge-pinning 2024.05.11.10.59.21.

@matthewfeickert
feat: Enable linux_ppc64le and linux_aarch64 build platforms
3f8476d 
* Enable linux_ppc64le and linux_aarch64 build platforms by adding provider
  keys.
   - c.f. https://conda-forge.org/docs/maintainer/conda_forge_yml/#provider
* Bump the build number.
@matthewfeickert matthewfeickert self-assigned this May 10, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

matthewfeickert
matthewfeickert commented May 10, 2024
View reviewed changes
conda-forge.yml Outdated
@@ -4,3 +4,6 @@ github:
conda_build:
error_overlinking: true
conda_forge_output_validation: true
provider:
linux_aarch64: default
linux_ppc64le: default
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgray how interested are you in the ppc64le builds? They haven't started yet (on Travis) after waiting for 40 minutes, so if they pass they will make builds very time consuming. If they are important we can try to keep them in, but I'm just wondering if this is a "nice to have" or "actually would be very important" platform.

matthewfeickert
matthewfeickert commented May 11, 2024
View reviewed changes
conda-forge.yml Outdated
Comment on lines 8 to 9
linux_aarch64: default
linux_ppc64le: default
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conda-forge/help-python is using CI services values other than default (as shown in the docs https://conda-forge.org/docs/maintainer/conda_forge_yml/#provider) strongly discouraged given the credits that conda-forge has? Or is experimentation with different CI services recommended to optimize build times overall?

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/fastjet-feedstock/actions/runs/9040062055.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits May 11, 2024 03:28
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert matthewfeickert mentioned this pull request May 11, 2024
Open
1 task
@matthewfeickert
Copy link
Member Author

The CI looks like all the checks are passing, but that's only because the linux_ppc64le jobs never ran on Circle CI, or if they did run, never reported back. c.f. conda-forge/conda-smithy#1926

@matthewfeickert
Copy link
Member Author

Circle CI is apparently not supported anymore: conda-forge/conda-smithy#1926 (comment)

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert
Copy link
Member Author

@conda-forge/help-ppc64le, are the linux_ppc64le jobs not running a known issue with Travis CI that is documented anywhere?

@matthewfeickert
Copy link
Member Author

Okay, given that the linux_ppc64le ran for over 4 hours without ever starting I'm going to assume that either Travis CI is just broken for these jobs or that linux_ppc64le support is effectively dead for conda-forge and the docs need to be updated.

image

So dropping linux_ppc64le and only using linux_aarch64 for this PR.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert matthewfeickert changed the title feat: Enable linux_ppc64le and linux_aarch64 build platforms feat: Enable linux_aarch64 build platform May 11, 2024
@matthewfeickert matthewfeickert marked this pull request as ready for review May 11, 2024 18:14
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please restart ci

@matthewfeickert matthewfeickert merged commit f73dac7 into conda-forge:main May 11, 2024
8 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-aarch64-and-ppc64le-builds branch May 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispap95 chrispap95 Awaiting requested review from chrispap95 chrispap95 is a code owner

@jmduarte jmduarte Awaiting requested review from jmduarte jmduarte is a code owner

@jpivarski jpivarski Awaiting requested review from jpivarski jpivarski is a code owner

@lgray lgray Awaiting requested review from lgray lgray is a code owner

Assignees

@matthewfeickert matthewfeickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert