-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gymnasium v0.29.1 with additional fixes #32
Conversation
…nda-forge-pinning 2023.08.21.16.28.48
…nda-forge-pinning 2024.02.20.09.46.26
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gymnasium-feedstock/actions/runs/7974980988. |
The only remaining failures are in linux-aarch64 and linux-ppc64le:
I wonder if there are any yum_requirements.txt or similar missing. |
Obviously I was too optimistic, Windows tests are failing with error:
While macOS test (except on Python 3.8) are failing with:
|
This problem may be related to conda-forge/sdl2_ttf-feedstock#18 . If that is true, I guess the problem is also affecting older releases of gymnasium and the workaround 6cba969 should make the test pass. |
Unfortunately also that fails, with error:
|
By looking at the discussion in #28 (comment) , this was supposed to fixed by Farama-Foundation/Gymnasium#480 that should be included in v0.29.1 . However, probably there was some regression between Farama-Foundation/Gymnasium#480 in May 2023 and v0.29.1 tag in August 2023. |
Indeed, the failing test was added ~10 days after Farama-Foundation/Gymnasium#480 : https://github.com/Farama-Foundation/Gymnasium/pull/525/files . |
@traversaro Farama-Foundation/Gymnasium#932 should fix the windows issues |
Thanks! |
After applying Farama-Foundation/Gymnasium#932 Windows is happy. |
@traversaro are the reminding issues related to Pygame? |
The OpenGL failures are probably due to Farama-Foundation/Gymnasium#480 not being propagated to the test added in https://github.com/Farama-Foundation/Gymnasium/pull/525/files . macos failures are due to some strange combination of how sdl_* libraries export their CMake config files (just on macos) and the version of sdl_* libraries used to build pygame, see conda-forge/sdl2_ttf-feedstock#18 . I think I can tackle this, but it will probably take some time. |
@ChristofKaufmann Do you understand the issue with Farama-Foundation/Gymnasium#480 and Farama-Foundation/Gymnasium#525? |
The amount of time I am hitting OpenGL-related problems (for example conda-forge/staged-recipes#25910 (comment)) may soon be pushing me toward that. However, I definitively need to understand more how a conda-forge |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gymnasium-feedstock/actions/runs/8482911048. |
Ok, network issues with anaconda.org website:
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.29.12.36.21
Interestingly, re-adding the logic to ignore |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gymnasium-feedstock/actions/runs/8490282239. |
OT, a first draft PR is available at conda-forge/staged-recipes#25919 . |
Ok, a bit of recap. The aarch64 tests are crashing as it is trying to run the |
@conda-forge/gymnasium the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM aside from some nits.
Thanks so much for chewing through this! 🙏
If you use the serialisation of the parametrised test as you see it in the logs, you can skip specific combinations. It would be great if we can robustify upstream to not segfault on missing jax, but in any case, skipping that test (even in its entirety) is a reasonable thing to do for now. PS. Please consider adding yourself as a maintainer here! 🙃 |
Comments addressed in 1ad9513 . |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.04.02.08.31.27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🙏
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Based on #31, with an additional mujoco < 3.0.0 constraint due to Farama-Foundation/Gymnasium#749, that will be fixed in gymnasium 1.0.0 .
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)