Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #13

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Update dependencies #13

merged 1 commit into from
Dec 3, 2021

Conversation

tjtg
Copy link
Contributor

@tjtg tjtg commented Dec 3, 2021

This PR updates the list of dependencies in the recipe to match the conda-forge environment file introduced in metoppv/improver#1589.

Other changes, such as running the unit test suite against the built conda package, will need to wait for a tagged release which includes changes from that PR, then create another PR on this repository.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tjtg tjtg changed the title Update dependencies from metoppv/improver#1589 Update dependencies Dec 3, 2021
Copy link
Contributor

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked that it matches envs/conda-forge.yml in improver. Just one question, do we need pip here?

@tjtg
Copy link
Contributor Author

tjtg commented Dec 3, 2021

Just one question, do we need pip here?

Pip is listed under the host requirements section. That makes it available when the package is getting built, so it can be used for the build script python -m pip install . -vv on line 15.
This usage of pip is recommended in the conda-forge docs and seems to be common in other feedstock repos such as iris and xarray.

@tjtg tjtg merged commit b31c49f into conda-forge:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants