Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build package #8

Closed
wants to merge 38 commits into from
Closed

Conversation

moritzwilksch
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run: pylance==0.10.5 must contain a space between the name and the pin, i.e. pylance ==0.10.5
  • requirements: run: retry>=0.9.2 must contain a space between the name and the pin, i.e. retry >=0.9.2
  • requirements: run: tqdm>=4.27.0 must contain a space between the name and the pin, i.e. tqdm >=4.27.0
  • requirements: run: pydantic>=1.10 must contain a space between the name and the pin, i.e. pydantic >=1.10
  • requirements: run: attrs>=21.3.0 must contain a space between the name and the pin, i.e. attrs >=21.3.0
  • requirements: run: semver>=3.0 must contain a space between the name and the pin, i.e. semver >=3.0
  • requirements: run: pyyaml>=6.0 must contain a space between the name and the pin, i.e. pyyaml >=6.0
  • requirements: run: click>=8.1.7 must contain a space between the name and the pin, i.e. click >=8.1.7
  • requirements: run: requests>=2.31.0 must contain a space between the name and the pin, i.e. requests >=2.31.0
  • requirements: run: overrides>=0.7 must contain a space between the name and the pin, i.e. overrides >=0.7
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@moritzwilksch moritzwilksch linked an issue Mar 29, 2024 that may be closed by this pull request
1 task
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • If python is a host requirement, it should be a run requirement.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@moritzwilksch
Copy link
Member Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 3 commits May 3, 2024 11:47
@xhochy
Copy link
Member

xhochy commented May 24, 2024

I wanted to debug this locally and thus added ARM architectures but for them, pylance is not available. Requested it via conda-forge/conda-forge-pinning-feedstock#5960

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The requirements section contained an unexpected subsection name. run_constraints is not a valid subsection name.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipe:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/build.sh Outdated Show resolved Hide resolved
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@xhochy
Copy link
Member

xhochy commented Jul 5, 2024

Confirmed locally that this works on osx-64 and osx-arm64

@moritzwilksch
Copy link
Member Author

should we consolidate this with #9 / #10?

@jan-janssen
Copy link
Member

should we consolidate this with #9 / #10?

I fixed all the issues in #12

@moritzwilksch
Copy link
Member Author

superseded by #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This shouldn't be a noarch package
5 participants