-
-
Notifications
You must be signed in to change notification settings - Fork 4
Update to 0.5.0 and add run_exports #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15972942954. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15835155228. Examine the logs at this URL for more detail. |
|
Even if we pass disabled werror, there are still failures werror-related: |
|
The actual issue was fixed by raspberrypi/libpisp#43, but I do not know how to add a patch in a meson wrap. |
As the only difference between v1.2.0 and v1.2.1 was exactly that fix, I just bumped the version. However, the upstream variant now fails with: For reference, the way libpisp avoids this is with https://github.com/conda-forge/libpisp-feedstock/blob/033f12999ceed1077e56499bdd0cc9deee0d7199/recipe/conda_build_config.yaml#L1 . |
All these problems come from the fact that since 0.5.0 release, also the upstream variant depends on libpisp, so as libpisp is already available in conda-forge (for the rpi variant) we can just depend on it, removing any related workaround. |
|
@carlodri the PR is ready for review, thanks. @wolfv @elephantum this will permit to unblock RoboStack/ros-kilted#21 and actually permit to install out of the box support for rasperrypi with |
|
This would be great! Hopefully @carlodri can review it swiftly :) |
|
Good for me! Thanks @traversaro |
Great, thanks! There is anything else to do before merging? |
|
Sorry @traversaro I thanked you but forgot to click merge....🥴😅 |
No problem, thanks! |
Fix #6 .
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)