Skip to content

Conversation

@traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 23, 2025

Fix #6 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from carlodri as a code owner June 23, 2025 21:06
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jun 23, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15972942954. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15835155228. Examine the logs at this URL for more detail.

@traversaro
Copy link
Contributor Author

Even if we pass disabled werror, there are still failures werror-related:

../subprojects/libpisp/src/libpisp/backend/backend_prepare.cpp:87:63: error: unused parameter 'lsc_extra' [-Werror=unused-parameter]

@traversaro
Copy link
Contributor Author

@traversaro
Copy link
Contributor Author

The actual issue was fixed by raspberrypi/libpisp#43, but I do not know how to add a patch in a meson wrap.

@traversaro
Copy link
Contributor Author

traversaro commented Jun 24, 2025

The actual issue was fixed by raspberrypi/libpisp#43, but I do not know how to add a patch in a meson wrap.

As the only difference between v1.2.0 and v1.2.1 was exactly that fix, I just bumped the version. However, the upstream variant now fails with:

FAILED: [code=1] subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o 
$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-c++ -Isubprojects/libpisp/src/libpisp.so.1.2.1.p -Isubprojects/libpisp/src -I../subprojects/libpisp/src -Isubprojects/libpisp/src/libpisp -I../subprojects/libpisp/src/libpisp -I/opt/conda/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O3 -DPISP_LOGGING_ENABLE=0 -Wno-address-of-packed-member -fvisibility-inlines-hidden -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/libcamera-0.5.0 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem $PREFIX/include -fPIC -pthread -MD -MQ subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -MF subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o.d -o subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -c ../subprojects/libpisp/src/helpers/media_device.cpp
In file included from ../subprojects/libpisp/src/helpers/media_device.hpp:17,
                 from ../subprojects/libpisp/src/helpers/media_device.cpp:9:
../subprojects/libpisp/src/helpers/v4l2_device.hpp: In member function 'bool libpisp::helpers::V4l2Device::isMeta()':
../subprojects/libpisp/src/helpers/v4l2_device.hpp:84:37: error: 'V4L2_BUF_TYPE_META_OUTPUT' was not declared in this scope; did you mean 'V4L2_BUF_TYPE_VBI_OUTPUT'?
   84 |                 return buf_type_ == V4L2_BUF_TYPE_META_OUTPUT;
      |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                     V4L2_BUF_TYPE_VBI_OUTPUT
ninja: build stopped: subcommand failed.

For reference, the way libpisp avoids this is with https://github.com/conda-forge/libpisp-feedstock/blob/033f12999ceed1077e56499bdd0cc9deee0d7199/recipe/conda_build_config.yaml#L1 .

@traversaro
Copy link
Contributor Author

The actual issue was fixed by raspberrypi/libpisp#43, but I do not know how to add a patch in a meson wrap.

As the only difference between v1.2.0 and v1.2.1 was exactly that fix, I just bumped the version. However, the upstream variant now fails with:

FAILED: [code=1] subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o 
$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-c++ -Isubprojects/libpisp/src/libpisp.so.1.2.1.p -Isubprojects/libpisp/src -I../subprojects/libpisp/src -Isubprojects/libpisp/src/libpisp -I../subprojects/libpisp/src/libpisp -I/opt/conda/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O3 -DPISP_LOGGING_ENABLE=0 -Wno-address-of-packed-member -fvisibility-inlines-hidden -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/libcamera-0.5.0 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem $PREFIX/include -fPIC -pthread -MD -MQ subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -MF subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o.d -o subprojects/libpisp/src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -c ../subprojects/libpisp/src/helpers/media_device.cpp
In file included from ../subprojects/libpisp/src/helpers/media_device.hpp:17,
                 from ../subprojects/libpisp/src/helpers/media_device.cpp:9:
../subprojects/libpisp/src/helpers/v4l2_device.hpp: In member function 'bool libpisp::helpers::V4l2Device::isMeta()':
../subprojects/libpisp/src/helpers/v4l2_device.hpp:84:37: error: 'V4L2_BUF_TYPE_META_OUTPUT' was not declared in this scope; did you mean 'V4L2_BUF_TYPE_VBI_OUTPUT'?
   84 |                 return buf_type_ == V4L2_BUF_TYPE_META_OUTPUT;
      |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                     V4L2_BUF_TYPE_VBI_OUTPUT
ninja: build stopped: subcommand failed.

All these problems come from the fact that since 0.5.0 release, also the upstream variant depends on libpisp, so as libpisp is already available in conda-forge (for the rpi variant) we can just depend on it, removing any related workaround.

@traversaro
Copy link
Contributor Author

@carlodri the PR is ready for review, thanks.

@wolfv @elephantum this will permit to unblock RoboStack/ros-kilted#21 and actually permit to install out of the box support for rasperrypi with camera_ros in conda-forge.

@wolfv
Copy link
Member

wolfv commented Jun 30, 2025

This would be great! Hopefully @carlodri can review it swiftly :)

@carlodri
Copy link
Contributor

Good for me! Thanks @traversaro

@traversaro
Copy link
Contributor Author

Good for me! Thanks @traversaro

Great, thanks! There is anything else to do before merging?

@carlodri
Copy link
Contributor

carlodri commented Jul 1, 2025

Sorry @traversaro I thanked you but forgot to click merge....🥴😅

@carlodri carlodri merged commit 352de63 into conda-forge:main Jul 1, 2025
18 checks passed
@traversaro
Copy link
Contributor Author

Sorry @traversaro I thanked you but forgot to click merge....🥴😅

No problem, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add run_exports?

4 participants