Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recipe to nvcomp 4.0.1. #15

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Update recipe to nvcomp 4.0.1. #15

merged 7 commits into from
Aug 28, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 27, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I updated the maintainers to @conda-forge/cuda as we have been doing for other similar feedstocks.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@bdice bdice marked this pull request as ready for review August 27, 2024 19:40
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented Aug 27, 2024

@conda-forge-admin, please rerender

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nvcomp-feedstock/actions/runs/10584940355.

jakirkham
jakirkham reviewed Aug 27, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@bdice @jakirkham
Update recipe/meta.yaml
0516e15 
Co-authored-by: jakirkham <jakirkham@gmail.com>
@bdice
Copy link
Contributor Author

bdice commented Aug 27, 2024

@conda-forge-admin, please rerender

jakirkham
jakirkham reviewed Aug 27, 2024
View reviewed changes
recipe/meta.yaml
- adibbley
- bdice
- jakirkham
- conda-forge/cuda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jakirkham jakirkham mentioned this pull request Aug 27, 2024
Merged
3 tasks
@jakirkham
Copy link
Member

Thanks Bradley! 🙏

There are a few test failures. However these look like potential issues with the redist. Will ask offline

@bdice bdice merged commit d62b9d8 into conda-forge:main Aug 28, 2024
7 checks passed
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Sep 5, 2024
@vuule
Upgrade to nvcomp 4.0.1 (#16076)
0cc059f 
This PR bumps nvcomp to 4.0.1.

Depends on:
- conda-forge/nvcomp-feedstock#15
- rapidsai/rapids-cmake#633
- rapidsai/kvikio#449

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Robert Maynard (https://github.com/robertmaynard)
  - Peixin (https://github.com/pxLi)
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #16076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@adibbley adibbley Awaiting requested review from adibbley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @jakirkham