Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.32.0] Backport cfitsio441 and numpy2 migrations #268

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Oct 1, 2024

  1. Rebuild for cfitsio 4.4.1

    (cherry picked from commit 272418c)
    regro-cf-autotick-bot authored and duncanmmacleod committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    11d91e3 View commit details
    Browse the repository at this point in the history
  2. Rebuild for numpy 2.0

    TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot
    PR has updated the recipe to account for the changes (see below for details).
    
    The biggest change is that we no longer need to use the oldest available numpy
    version at build time in order to support old numpy version at runtime - numpy
    will by default use a compatible ABI for the oldest still-supported numpy versions.
    
    Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a
    run requirement - this has been handled for more than two years now by a
    run-export on the numpy package itself. The migrator will therefore remove
    any occurrences of this.
    
    However, you will still need to add the lower bound for the numpy version,
    in line with what the upstream package requires. The default lower bound from
    the run-export is `>=1.19`; if your package needs a newer version than that,
    please add `numpy >=x.y` under `run:`.
    
    Finally, by default, building against numpy 2.0 will assume that the package
    is compatible with numpy 2.0, which is not necessarily the case. You should
    check that the upstream package explicitly supports numpy 2.0, otherwise you
    need to add a `- numpy <2.0dev0` run requirement until that happens (check numpy
    issue 26191 for an overview of the most important packages).
    
      * [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility)
        * If upstream is not yet compatible with numpy 2.0, add `numpy <2.0dev0` upper bound under `run:`.
        * If upstream is already compatible with numpy 2.0, double-check their supported numpy versions.
        * If upstream requires a minimum numpy version newer than 1.19, you need to add `numpy >=x.y` under `run:`.
      * [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed.
    
    PS. If the build does not compile anymore, this is almost certainly a sign that
    the upstream project is not yet ready for numpy 2.0; do not close this PR until
    a version compatible with numpy 2.0 has been released upstream and on this
    feedstock (in the meantime, you can keep the bot from reopening this PR in
    case of git conflicts by marking it as a draft).
    
    (cherry picked from commit cd44995)
    regro-cf-autotick-bot authored and duncanmmacleod committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    520070e View commit details
    Browse the repository at this point in the history
  3. MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.40.1, and co…

    …nda-forge-pinning 2024.10.01.11.40.29
    duncanmmacleod committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0c9b1e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. remove external afterimage

    this is deprecated upstream
    
    (cherry picked from commit cdeff5f)
    duncanmmacleod committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    260af5f View commit details
    Browse the repository at this point in the history
  2. remove ld_impl hack

    (cherry picked from commit c71df7e)
    duncanmmacleod committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    51ae4c1 View commit details
    Browse the repository at this point in the history
  3. fix cross-compilation for builtin afterimage

    cherry picked from conda-forge/afterimage-feedstock@23df316
    
    (cherry picked from commit 2a85d67)
    duncanmmacleod committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cedd9bc View commit details
    Browse the repository at this point in the history