-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zppy + zstash to conda-forge #21883
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/zppy:
For recipes/zstash:
|
@mahf708, please also add @tomvothecoder, @forsyth2 and @chengzhuzhang. Tom, Jill and Ryan, please post here verifying that you agree to be mainainers. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/zppy:
For recipes/zstash:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/zppy:
For recipes/zstash:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/zppy:
For recipes/zstash:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/zstash:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I fixed all the obvious linting errors. I will have a closer look upstream to ensure we are doing this correctly. This will still likely fail |
I agree to be a maintainer. Other questions:
|
You will get access to the repos (they will be named zppy-feedstock and zstash-feedstock) once this PR is merged. I can add you to this PR to edit, if you'd like, but there is no need. We will discuss what to do about the "upstream" tools/actions separately (I will need to consult with Xylar about what's best to do) |
Thanks @xylar, I just copied the recipes from upstream. Please take another look when you get a chance |
@mahf708 and @forsyth2, the Linux checks are failing because of the discrepancy I mentioned in E3SM-Project/zstash#201 (comment). We will need to get this figured out before we can proceed. |
@mahf708, it seems like maybe things are going to need to be fixed upstream so |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python and so here I am doing that. |
@mahf708, I don't think there's any need to merge the |
You're right... a bad subconscious habit 🤷 |
@mahf708, I don't think it hurts to have asked for a review because it can take awhile but we're still resolving: It's important that a reviewer doesn't merge this until those have been resolved. |
Ah sorry, I thought we were more or less done with the PRs. My bad. Let's wait until we are 100% sure and we will move forward then |
Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
@xylar are we good to go? Should I make this PR ready for review? |
Okay, looks good. Yes, I think this is ready for review. |
@conda-forge-admin, please ping conda-forge/help-python, ready for review, thanks! These two packages are mostly for HPC usage for the E3SM project, and we thought it would be better to house them on conda-forge here than private channels. Thank you! The Windows failure is expected, these are mostly linux-64 packages and we do not guarantee anything beyond that. |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python and so here I am doing that. |
@xylar could you nudge the team? I cannot do it because this is a new account. |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python, and so here I am doing that. |
@mahf708, I prefer not to. They are busy and this isn't urgent. I only nudge them when it's urgent and that makes it more likely that my nudges are taken seriously. |
Ignoring noarch Windows build failure due to missing dependency. |
@dopplershift, much appreciated! |
Need to fix:
--
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).