Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Biogeme #26374
Add Biogeme #26374
Changes from all commits
a6618e0
63659a1
de7f8c3
42135ff
28e80ac
f780af2
677dd86
beb61a0
4e0d84f
f157eb3
1d415c4
a2a77a1
77bed29
5966602
b361fa3
0c9193c
548702c
572126e
940b49f
cc80118
2648622
089c7ef
6e4b391
fc0bd68
dce48f7
e66ddff
2b807c2
29dc69d
3c3c422
c69bc86
86cb324
d2271c5
5c6a480
9b30c8a
394a262
8e9a1cb
8cce67b
98657c0
bd3de4b
64b8696
e6cbaa7
1c1032b
f47670a
e41b3f1
1394102
090e402
c7e4787
206caa3
c5ccae3
b7ee6f5
98e8d96
3fb7332
a5b888c
83712c4
930d5a6
aad5714
a12b934
a8c050d
7da5d80
ddaecfd
e40658f
3b12f1a
1bdcc45
7363907
7e2b86a
1ff3d86
00f2d1a
dd4e360
52c4645
7f5b941
d8ac7bf
b634c68
e4f2982
dbfad1f
191fb5c
4bdbe13
04f8568
a66ed8f
90eef21
0dbc13e
c70e74a
6227321
0e26491
29a7ba9
8c45729
edbd25b
f7964d4
a759d95
ca058c5
ba9e2a2
0ee164b
bd12db2
50c8984
0306cc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a version restriction in the biogeme-optimization dependencies: https://github.com/michelbierlaire/optimization/blob/main/pyproject.toml#L28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The author of biogeme compiled cythonbiogeme against numpy 2, so it should be fine with numpy 1. We really need to be able to install this with numpy 1 and that is why I recommended not following upstream. I've opened an issue upstream to see if the author will correct this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened both of these:
michelbierlaire/biogeme#40
michelbierlaire/cythonbiogeme#21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will help manage this in the feedstock repo and if we really have to add a restriction to numpy 2 we will, but there should be no issues with this and if someone reports something on the feedstock I can give my word to help resolve it. Can that possibly be sufficient? I maintain many feedstocks and haven't had any past issues with similar decisions when upstream authors are a bit to heavy with the pins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok, thanks for the explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @moorepants should I add you as a maintainer on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, and you have no objection to adding the
dev_url
, I assume? If not, then I'll wait a couple hours for @FGarridoV to chime, then push the necessary changes and merge. That way you can both start testing and tuning as needed. I know you have an imminent deadline.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one took a little while to find 😀, so listing it explicitly would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this dev_url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the dependencies that are found in the
pyproject.toml
file in biogeme 3.12.4:All will need to be included here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the version restriction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ipython isn't even really a dependency, it is never imported in the modules. I think this is also a mistake from the upstream author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems harmless to include now, and it can always be removed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dev URL is really handy for checking for dependency changes when the conda-forge bot opens pull requests for new versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this dev_url