Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add antspyx #28151

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

add antspyx #28151

wants to merge 15 commits into from

Conversation

Dhananjhay
Copy link
Contributor

@Dhananjhay Dhananjhay commented Nov 8, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

github-actions bot commented Nov 8, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 8, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/antspyx/meta.yaml) and found some lint.

Here's what I've got...

For recipes/antspyx/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12]
  • There are 1 too many lines. There should be one empty line at the end of the file.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/antspyx/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/antspyx/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/antspyx/meta.yaml:

  • libgcc-ng has been superseded by libgcc. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("c") }} and {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("c") }}    # depending on which...
        - {{ compiler("cxx") }}  # ... compilers you use
  • libstdcxx-ng has been superseded by libstdcxx. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("cxx") }}

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/antspyx/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants