Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v3.0.1 #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

felipepaes
Copy link

Hi everyone o/
I'll be helping maintaining the project

@xmnlab ,please, let me know if there is any change needed

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xmnlab
Copy link
Member

xmnlab commented Oct 26, 2023

@conda-forge-admin, please rerender

recipe/meta.yaml Outdated
- bleach >=3.0.2,<4.0.0
- cachelib >=0.4.1,<0.5
- python >=3.8,<=3.11
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- python

@xmnlab
Copy link
Member

xmnlab commented Oct 26, 2023

@felipepaes I asked the conda-forge bot to rerender this feedstock, so please update your branch locally.

additionally, please reset the build number to 0 here: https://github.com/conda-forge/superset-feedstock/pull/29/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR16

as you are proposing a new version, the build number should start with 0

@xmnlab
Copy link
Member

xmnlab commented Oct 26, 2023

@felipepaes ... I am not really sure about this error ... but just from the error message, I would suggest to remove these lines https://github.com/conda-forge/superset-feedstock/pull/29/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR27-R28

@felipepaes
Copy link
Author

@xmnlab I made the changes but it is still failing, maybe I should add these lines back?

 - __unix  # [unix]
 - __win   # [win]

@SaravananSathyanandhaQC

@conda-forge-admin, please rerender

@SaravananSathyanandhaQC

@felipepaes I think the requirements weren't quite right in that version of superset - I would go to 3.0.4 where flask-caching was bumped to 2.x (or just go straight to 3.1.x now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants