Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested changes for token support (#16) #22

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Conversation

kenodegard
Copy link
Contributor

The gist of these changes:

  • removes ExtraContext, this is redundant with what is aggregated and provided in the ctx (click.Context) object
  • adds not_reuqired_if logic to custom option so click will properly handle the error handling (instead of handling it post processing in get_auth_manager)
  • rename conda_auth.hooks to conda_auth.plugin per the naming pattern established elsewhere (see Convert conda-build entrypoints into plugins conda/conda-build#4921 (comment))
  • add -h support (to match what conda itself supports)

Controversial/opinionated changes that I'm indifferent about:

  • inlined minor helper functions that have minimal usage (1-2 calls)

@travishathaway travishathaway changed the base branch from add-token-support to main October 21, 2023 05:04
Copy link
Collaborator

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks 😄

@travishathaway travishathaway merged commit ac3c143 into main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants