Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build conda store cli #1019

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Dec 10, 2024

part 2 to address #911

Description

This PR removes steps for building and releasing conda-store (the cli). This includes:

  • removing the split package from the conda build recipe - now the recipe will just build the conda-store-server
  • Removing conda-store (cli) build tasks from the CI (this also removes the release build tasks)
  • Removing conda-store integration tests from the CI
  • Removing conda-store steps from cut-release-pr script

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@soapy1 soapy1 marked this pull request as draft December 10, 2024 19:51
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit 261bbcc
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/678035ab88ffb7000868380b
😎 Deploy Preview https://deploy-preview-1019--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soapy1 soapy1 marked this pull request as ready for review December 10, 2024 20:05
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @soapy1 this is going in the right direction, I think since you are already going through removing the build for conda-store (cli) we might as well refactor the workflows to remove redundant matrix bits

.github/workflows/build_pypi_package.yaml Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
docusaurus-docs/conda-store/how-tos/install-standalone.md Outdated Show resolved Hide resolved
@trallard
Copy link
Collaborator

Another thought we would need to add a note somewhere about stopping releasing the cli as a separate package

@soapy1
Copy link
Contributor Author

soapy1 commented Dec 11, 2024

Another thought we would need to add a note somewhere about stopping releasing the cli as a separate package

There are a few public places that users will be able to see this change:

  • this pr
  • release notes (for the next release)
  • pr to conda-forge package that removes the conda-store package

I think release notes is an appropriate place to be broadcasting this change to communicate with users that this change is coming.

Are there any other stream of news that a conda-store user would be looking at to get this type of information?

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Did the recipe/meta.yaml just come from the conda-store-server conda package?

EDIT: Just saw that they were un-nested from the outputs section. Sorry!

@soapy1
Copy link
Contributor Author

soapy1 commented Dec 16, 2024

Did the recipe/meta.yaml just come from the conda-store-server conda package?

Nope, I edited it for this PR. We'll need to update the conda-store-server package to match this for next release though.

@soapy1 soapy1 requested a review from trallard December 16, 2024 20:53
@soapy1 soapy1 force-pushed the dont-build-conda-store-cli branch from a936f10 to 5892e57 Compare December 17, 2024 17:24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not building the Docker image shall we also remove the Dockerfile?
There does not seem to be a reason to keep straggling files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it would be better to remove all the conda-store directory at the same time opposed to piecemeal removing pieces.

@soapy1 soapy1 force-pushed the dont-build-conda-store-cli branch from 9b3d8ce to f7a66e0 Compare December 17, 2024 17:34
@soapy1 soapy1 requested a review from trallard December 18, 2024 17:56
@soapy1 soapy1 force-pushed the dont-build-conda-store-cli branch from b3b0325 to 89a2bb5 Compare January 2, 2025 16:52
.github/workflows/build_pypi_package.yaml Outdated Show resolved Hide resolved
.github/workflows/build_pypi_package.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of places where we use conda-store-server, which might change as we consolidate the packages. I suggest setting a job-level env variable for this and reusing the variable instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the amount of effort it will take to introduce a job-level variable will be pretty similar to the amount of effort it will take to explicitly rename things. Since (1) we should only be renaming conda-store-server -> conda-store once, and (2) it is easier to read + debug yaml files (and ci) that use explicit names opposed to variables, I would prefer not to introduce this variable.

But open to doing it if I'm missing an important upside that it will provide. I think it would be appropriate to do that work in a follow up PR

README.md Show resolved Hide resolved
docusaurus-docs/community/contribute/local-setup-core.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/introduction.md Outdated Show resolved Hide resolved
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@soapy1 soapy1 force-pushed the dont-build-conda-store-cli branch from 21a5d54 to d6a2f63 Compare January 6, 2025 16:57
@soapy1 soapy1 requested a review from trallard January 6, 2025 17:06
@soapy1 soapy1 changed the title Dont build conda store cli Don't build conda store cli Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review 👀
Development

Successfully merging this pull request may close these issues.

3 participants