-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert conda-build entrypoints into plugins #4921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, this'll require a run constraint for a newer version of conda!
@jezdez added but technically not necessary? the old interface is still there and the plugin system is only imported in |
@kenodegard, I was testing this out locally today, and one thing I noticed is that the commands show up twice on the Is there anything we can do to prevent that? I think that would require a change on the conda side. |
I think we should stop shipping |
conda-build's various subcommands will continue to be listed twice until conda is modified to exclude duplicates (probably the correct route?) or the executables are deprecated/removed while the subcommand displaying twice is noisy its not incorrect (the legacy plugins are still there) and IMO isn't enough to block this PR |
Description
Might as well make conda-build into a proper plugin too!
This introduces a new submodule,
conda.cli.plugins
, where the pluggy hookimpls live. Otherwise minimal changes were made.This also marks the legacy style plugin interfaces as deprecated, e.g.:
Resolves #4922
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?