Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sys.exit call in conda_build.build.tests_failed #5370

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

beeankha
Copy link
Member

Description

Replacing sys.exit call in tests_failed() in build.py with the new CondaBuildUserError exception for better error handling, along with a corresponding unit test.

This work has been separated out from #5255
Xref #4209

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@beeankha beeankha self-assigned this Jun 11, 2024
@beeankha beeankha requested a review from a team as a code owner June 11, 2024 22:24
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 11, 2024
Copy link

codspeed-hq bot commented Jun 11, 2024

CodSpeed Performance Report

Merging #5370 will not alter performance

Comparing beeankha:sys.exit-tests_failed (1e46f60) with main (7d74dd6)

Summary

✅ 3 untouched benchmarks

@beeankha beeankha removed their assignment Jun 13, 2024
kenodegard
kenodegard previously approved these changes Jun 17, 2024
@kenodegard kenodegard enabled auto-merge (squash) June 17, 2024 07:29
@kenodegard kenodegard merged commit 4457362 into conda:main Jun 18, 2024
28 checks passed
@beeankha beeankha mentioned this pull request Jul 16, 2024
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants