Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 24.9.x back into main #5491

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Merge 24.9.x back into main #5491

merged 3 commits into from
Sep 19, 2024

Conversation

beeankha
Copy link
Contributor

Description

Xref #5481

Warning

DO NOT SQUASH MERGE!

minrk and others added 2 commits September 18, 2024 09:32
* discard unused variants before copying metadata

when variant matrix is large and mostly unused (as in conda-forge),
the length of input_variants may be several thousand
when only a few are actually used.

This causes `get_loop_vars` and `metadata.copy()` to become very expensive.

* try reducing with all used vars instead of loop vars

should reduce less

* perf: copy distributed variants list after subsetting

vastly reduces the number of copies computed for large variant matrices

* perf: pass used_vars subset to get_loop_vars

rather than computing all loop vars and then intersecting,
only consider relevant keys when computing loop vars

reduces get_used_loop_vars from O(n_vars * n_variants) to O(n_used_vars * n_variants)

* remove redundant deepcopy of config.variant

config.copy already copies this, no need to do it twice in metadata.copy

* add config.copy_variants method

to avoid calling pickle in too many places

* Update news/5392-variant-copy

* Add benchmark test for `render_recipe` (#5490)

---------

Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
Co-authored-by: Bianca Henderson <beeankha@gmail.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
* Update .authors.yml

* Update news

* Updated authorship for 24.9.0

* Updated CHANGELOG for 24.9.0

---------

Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@beeankha beeankha added source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package labels Sep 18, 2024
@beeankha beeankha self-assigned this Sep 18, 2024
@beeankha beeankha requested a review from a team as a code owner September 18, 2024 18:08
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 18, 2024
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #5491 will not alter performance

Comparing 24.9.x (c7df147) with 24.9.x (9133820)

Summary

✅ 4 untouched benchmarks

@kenodegard kenodegard mentioned this pull request Sep 18, 2024
3 tasks
@kenodegard kenodegard merged commit 81c9bc4 into main Sep 19, 2024
54 checks passed
@kenodegard kenodegard mentioned this pull request Sep 19, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

4 participants