Abstract miniconda.rst template #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kathatherine
requested changes
Jul 5, 2023
docs/source/miniconda.rst
Outdated
| @@ -56,29 +56,29 @@ Windows installers | |||
|
|
|||
| Python 3.10,`Miniconda3 Windows 64-bit <https://repo.anaconda.com/miniconda/Miniconda3-py310_23.3.1-0-Windows-x86_64.exe>`_,53.9 MiB,``307194e1f12bbeb52b083634e89cc67db4f7980bd542254b43d3309eaf7cb358`` | |||
| Python 3.9,`Miniconda3 Windows 64-bit <https://repo.anaconda.com/miniconda/Miniconda3-py39_23.3.1-0-Windows-x86_64.exe>`_,53.7 MiB,``155958e7922d8b7aa6cb3115aeb66d2efcdae1237a6f1c11e23ca75ea96d291a`` | |||
| ,`Miniconda3 Windows 32-bit <https://repo.anaconda.com/miniconda/Miniconda3-py39_23.3.1-0-Windows-x86.exe>`_,67.8 MiB,``4fb64e6c9c28b88beab16994bfba4829110ea3145baa60bda5344174ab65d462`` | |||
There was a problem hiding this comment.
Seems like we're missing the Python version at the beginning of these additions.
There was a problem hiding this comment.
That is correct. It will end up looking like the macOS installers: https://docs.conda.io/en/latest/miniconda.html#macos-installers
Right now, Windows is the only platform that doesn't sort by python version, but by platform, which is inconsistent.
To be honest, I wouldn't be against removing win-32 entirely. It hasn't been supported in a while.
There was a problem hiding this comment.
Ah, gotcha. I forgot these lists were creating tables.
There was a problem hiding this comment.
I did just notice that the Miniconda version for win-32 was not correct though. I fixed that part.
kathatherine
previously approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
jinja2template requires a lot of manual labor to update. To remove or add a python version, the template needs to be changed in multiple places and thecreate_miniconda_rst.pyfile needs to be updated, which is error prone. Currently,miniconda.rstdoes not correspond to thejinja2file anymore either.This PR abstracts the
jinja2template to minimize the number of changes needed for updating the release tables.Changes:
jinja2template for Miniconda installersfiles.jsonfile.Notable differences in the output:
AMDpart for Apple M1 installers is removed and is now consistent with the "latest" Miniconda description.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?