Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes script #871

Merged
merged 41 commits into from
Jul 11, 2023
Merged

Release notes script #871

merged 41 commits into from
Jul 11, 2023

Conversation

Jrice1317
Copy link
Contributor

@Jrice1317 Jrice1317 commented Jul 11, 2023 •
edited
Loading

Description

This PR will create release notes for Miniconda from constructor outputs.

Changes:

  • Add Release Notes script and template
  • Add data for Miniconda 23.5.0-3 used to generate Release Notes for current release
  • Add link to Release Notes to miniconda.rst

The screenshot below is a snippet of what the rst file generated by the script looks like.
Screen Shot 2023-07-11 at 2 45 10 PM

Contributors:

Checklist - did you ...

  • [ - ] Add a file to the news directory (using the template) for the next release's release notes?
  • [ - ] Add / update necessary tests?
  • [ - ] Add / update outdated documentation?

Jrice1317 and others added 30 commits June 29, 2023 13:39
@Jrice1317
initial commit
f25d703
@Jrice1317
initial commit
4d37907
@Jrice1317
JSON parser
7039a9e
@Jrice1317
example of parsed info
0570da1
@Jrice1317
example info.json
675584e
@Jrice1317
Adding examples
243e8f8
@Jrice1317
Address PR comments
7048d87
@Jrice1317
Remove redudant code
ba05c86
@Jrice1317
Merge pull request #3 from Jrice1317/json_parser
0ff9b5c 
JSON Parser
@Jrice1317 @marcoesters
Iterate through miniconda_releases dir
cd64655 
Co-authored-by: Marco Esters <marcoesters@users.noreply.github.com>
@Jrice1317
Debug packages without build nums
b0e67e5
@Jrice1317
Add info_json files
d9216dc
@marcoesters
Merge branch 'conda:main' into release_notes_script
b64739d
@Jrice1317
Remove info.json to keep only latest (py311)
c574fbe
@Jrice1317
Merge pull request #5 from Jrice1317/json_parser
63bd76e 
Iterate through miniconda_releases dir
@marcoesters
Add changes for 23.5.0
8e04d3c
@marcoesters
Add link to patch file
32fa922
@marcoesters
Add release notes link
7f6938a
@Jrice1317 @marcoesters
Final touches to create_release_notes.py
148211b 
Co-authored-by: Marco Esters <marcoesters@users.noreply.github.com>
@Jrice1317
Release notes rst.jinja2 template
2bdbabf
@marcoesters @Jrice1317
Update docs/source/miniconda_releases/23.5.0-1/changes.rst
ece5f76 
Co-authored-by: Jaida Rice <100002667+Jrice1317@users.noreply.github.com>
@Jrice1317
Update headings syntax to align with AD
062b782
@marcoesters
Merge pull request #7 from marcoesters/changes-23.5.0
f876796 
Add changes for version 23.5.0
@marcoesters @Jrice1317
Update docs/source/miniconda.rst
1680d0a 
Co-authored-by: Jaida Rice <100002667+Jrice1317@users.noreply.github.com>
@marcoesters @Jrice1317
Update docs/source/miniconda.rst.jinja2
6ecf98b 
Co-authored-by: Jaida Rice <100002667+Jrice1317@users.noreply.github.com>
@marcoesters
Merge pull request #8 from marcoesters/release-notes-link
4d4b78e 
Add release notes link
@Jrice1317 @marcoesters
Update docs/source/create_release_notes.py
287fc89 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@Jrice1317
Merge pull request #9 from Jrice1317/json_parser
50f12bb 
Release Notes Script Updates and rst.jinja2 Template
@Jrice1317
Create release notes for Miniconda-23.5.0-3
3284ca0
@Jrice1317
Remove uppercase from platform titles
d96ae1f
@conda-bot conda-bot mentioned this pull request Jul 11, 2023
Merged
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @Jrice1317.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#788), and ping the bot to refresh the PR.

@Jrice1317 Jrice1317 marked this pull request as ready for review July 11, 2023 22:10
kathatherine
kathatherine requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things!

docs/source/miniconda_release_notes.rst Outdated Show resolved Hide resolved
docs/source/miniconda_release_notes.rst Outdated Show resolved Hide resolved
docs/source/miniconda_releases/23.5.0-3/changes.rst Outdated Show resolved Hide resolved
@kenodegard
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 11, 2023
Jrice1317 and others added 3 commits July 11, 2023 15:33
@Jrice1317 @kathatherine
Update docs/source/miniconda_release_notes.rst
1f07e1d 
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@Jrice1317 @kathatherine
Update docs/source/miniconda_releases/23.5.0-3/changes.rst
a572729 
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@Jrice1317
Update miniconda_release_notes.rst
ea3ebbe
kathatherine
kathatherine previously approved these changes Jul 11, 2023
View reviewed changes
kathatherine
kathatherine previously approved these changes Jul 11, 2023
View reviewed changes
marcoesters
marcoesters reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the headers should have consistency, or the font sizes will keep changing inside each release note

docs/source/miniconda_release_notes.rst.jinja2 Outdated Show resolved Hide resolved
docs/source/miniconda_release_notes.rst.jinja2 Outdated Show resolved Hide resolved
docs/source/miniconda_release_notes.rst Outdated Show resolved Hide resolved
docs/source/miniconda_release_notes.rst Outdated Show resolved Hide resolved
@Jrice1317 @marcoesters
Update docs/source/miniconda_release_notes.rst.jinja2
ad1016b 
Co-authored-by: Marco Esters <mesters@anaconda.com>
Jrice1317 and others added 3 commits July 11, 2023 16:11
@Jrice1317 @marcoesters
Update docs/source/miniconda_release_notes.rst.jinja2
6ded1bb 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@Jrice1317 @marcoesters
Update docs/source/miniconda_release_notes.rst
475be4f 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@Jrice1317 @marcoesters
Update docs/source/miniconda_release_notes.rst
0bfd2b0 
Co-authored-by: Marco Esters <mesters@anaconda.com>
marcoesters
marcoesters approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marcoesters marcoesters merged commit 3b01385 into conda:main Jul 11, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoesters marcoesters marcoesters approved these changes

@kathatherine kathatherine kathatherine left review comments

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jrice1317 @conda-bot @kenodegard @marcoesters @kathatherine