Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new CLA reviewer sub-team #136

Closed
2 tasks done
Tracked by #1
jezdez opened this issue May 7, 2024 · 20 comments
Closed
2 tasks done
Tracked by #1

Create a new CLA reviewer sub-team #136

jezdez opened this issue May 7, 2024 · 20 comments

Comments

@jezdez
Copy link
Member

jezdez commented May 7, 2024

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

To facilitate the review of incoming Adobe Sign CLA signatures, we'll need to create a "CLA Reviewers" subteam per governance policy.

Why is this needed?

@conda/steering-council Opinions on this proposal?

Proposal

I'm proposing to form a new "CLA Reviewers" subteam to help with conda/cla#1

Team Charter

Following the governance policy, this is a static charter with the condition that the new CLA Reviewers team only consists of steering council members for compliance reasons.

The "CLA Reviewers" subteam helps with reviewing, facilitating feedback and approving (or denying) incoming CLA documents, through a public pull request based process.

The CLA documents will be accessible to the team via a NumFOCUS provided Google Drive or similar.

This new team will be responsible for taking on the work that the "Infrastructure" team has done while reviewing similar signed documents of the previous Anaconda Inc-specific CLA.

To reduce the risk of bottlenecks in processing new CLA documents, the team must have at least 3 active members, and automatically fall back to the whole conda steering council if that number falls below it.

Work areas

  • review incoming signed CLA documents via Adobe sign
  • approving PRs in the repository where new CLA requests arrive (e.g. conda/infrastructure or conda/governance) as PR based on the process described in Update CLA process to match new requirements from NumFOCUS cla#1
  • responding to requests by the rest of the conda steering council, NumFOCUS legal etc

Scope

The "CLA Reviewer" team works as delegates of the conda steering council and follows the Conda Code of Conduct.

Here are copies of the new NumFOCUS specific CLA (location not final):

Proposed members:

@jaimergp
Copy link
Contributor

jaimergp commented May 7, 2024

Add me please :)

@chenghlee
Copy link
Contributor

I'm all for having this subteam, but I'm a little confused how this would work:

any member of the new CLA Reviewers is also a steering council member.

The way I'm reading it, this could dramatically increase the size of the steering council, which, e.g., could make getting quorum for CEP votes more complicated. Also, wouldn't the shared funding rule imply that no more than two employees per company could be on this subteam?

I can see requiring a minimum number of steering council members to be present on this subteam, particularly to "[respond] to requests by the rest of the conda steering council or NumFOCUS legal".

(It's also quite possible that I'm mis-reading that clause.)

@jaimergp
Copy link
Contributor

jaimergp commented May 7, 2024

I think it's more about "only steering can be CLA reviewer", and not "a CLA reviewer will become steering".

@jezdez
Copy link
Member Author

jezdez commented May 7, 2024

I think it's more about "only steering can be CLA reviewer", and not "a CLA reviewer will become steering".

Yes, that’s what I meant, sorry for the confusion, I’ll update the proposal.

@jezdez
Copy link
Member Author

jezdez commented May 8, 2024

I've added links to the two Adobe Acrobat hosted files (CLA documentation, that will be part of the regular conda docs) and the actual CLA form to sign in the future.

@jezdez
Copy link
Member Author

jezdez commented May 10, 2024

@conda/steering-council

Vote

This proposal falls under the "Sub-team Formation" policy of the conda governance policy, please vote and/or comment on this proposal.

It needs 50 % of the Steering Council to vote yes to pass.

To vote, please leave yes, no or abstain as comments below.

If you would like to propose changes to the current proposal or have questions, please leave a comment below as well.

This vote will end on 2024-05-17, End of Day, Anywhere on Earth (AoE).

@jezdez jezdez added the vote Voting following governance policy label May 10, 2024
@jezdez
Copy link
Member Author

jezdez commented May 10, 2024

yes

1 similar comment
@ocefpaf
Copy link
Contributor

ocefpaf commented May 10, 2024

yes

@msarahan
Copy link
Contributor

Yes

@baszalmstra
Copy link
Contributor

yes

1 similar comment
@wolfv
Copy link
Contributor

wolfv commented May 10, 2024

yes

@xhochy
Copy link
Contributor

xhochy commented May 10, 2024

Yes

@jjhelmus
Copy link
Contributor

yes

@chenghlee
Copy link
Contributor

Yes

@kkraus14
Copy link
Contributor

yes

1 similar comment
@jaimergp
Copy link
Contributor

yes

@mbargull
Copy link
Member

Yes

@travishathaway
Copy link

Not a steering council member, but I would like to be added to this team to help with the CLA review process.

@jezdez jezdez removed the vote Voting following governance policy label Jun 4, 2024
@jezdez
Copy link
Member Author

jezdez commented Jun 4, 2024

(note: this vote was at first erroneously called not having reached quorum and passing due GitHub hiding some of the votes as spam 🤦🏻)

Voting Results

This was a standard, non-timed-out vote.

Among Steering Council members there are 10 "yes", 0 "no", and no abstentions.

Among Emeritus Steering Council members there are 1 "yes", 0 "no", and no abstentions.

This vote has reached quorum (10 is at least 50% of 15 active steering council members).

It has also passed since it recorded 11 "yes" votes and 0 "no" votes giving 11/11 which is greater than 50% of 11.

@jezdez
Copy link
Member Author

jezdez commented Jun 4, 2024

I've created the @conda/cla-reviewers team and populated it with the members listed in the issue description. Please let me know if anyone in the @conda/steering-council has feedback or wants to participate in the upcoming process.

To facilitate the review and storage of CLA applications and signees, I've also created a new https://github.com/conda/cla repo, to have a single source of truth who has signed the new CLA (but not store the actual PDFs of course). I've also assigned that repo to the steering council.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests