Fix tests #552
Fix tests #552
Conversation
args.url_pypi_metadata has a default value and will never be empty. To check if both options aren't given, we have to check if it's different fro the default value.
A small bug was introduced when adding v1 format. The "meta.yaml" file was always created in the current directory instead of recipe_dir.
pypi.org is the official domain. See pypi/warehouse#2184
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Fix: Mixing implicit and explicit returns may indicate an error as implicit returns always return None
Bump version to 0.2.2. Version 0.1.0 includes versioneer.py which isn't compatible with Python 3.12 (using SafeConfigParser).
Bump gsw version to 3.6.19. Version 3.3.1 includes versioneer.py which tries to import SafeConfigParser that was removed in Python 3.12. "packages" key isn't detected anymore as most metadata were moved to pyproject.toml. Only C extension definition is left in setup.py.
Bump gsw version to 3.6.19. Version 3.3.1 includes versioneer.py which tries to import SafeConfigParser that was removed in Python 3.12.
Package setup.py not compatible with 3.12 (try to import imp). New package to find for this test. Skip for now.
| [ | ||
| "cython >=3", | ||
| "numpy >=2.0.0rc1", | ||
| "oldest-supported-numpy", |
There was a problem hiding this comment.
We shouldn't have both numpy >=2.0.0rc1 and oldest-supported-numpy but it looks like grayskull doesn't support selectors?
There was a problem hiding this comment.
which selectors are you talking about? It does support a few of them but in this case they might not be being generated for some reason
There was a problem hiding this comment.
Yeah this is requirements/host. Don't think we want oldest-supported-numpy here
There was a problem hiding this comment.
see my comment here ;)
https://github.com/conda/grayskull/pull/552/files#r1721631804
There was a problem hiding this comment.
that equal over there is just a syntax sugar, but if you properly compare the numpy and oldest-supported-numpy you will see the selectors :)
There was a problem hiding this comment.
Ah! Indeed, looking at the generated meta.yaml, I see:
- oldest-supported-numpy # [py<39]
- numpy >=2.0.0rc1 # [py>=39]
|
thanks for fixing the tests, much appreciated! :) |
| ) | ||
| assert sorted(recipe["requirements"]["run"]) == sorted( | ||
| ["cython", "python", "<{ pin_compatible('numpy') }}"] | ||
| ["<{ pin_compatible('numpy') }}", "oldest-supported-numpy", "python >=3.9"] |
There was a problem hiding this comment.
Also not sure why oldest-supported-numpy is added to requirements/run
There was a problem hiding this comment.
Hi @jakirkham , at first sight it seems odd, indeed, but it comes directly from the requirements in that package gsw, it is not something that grayskull adds,
https://github.com/TEOS-10/GSW-Python/blob/c3407368ef01d0b3d8e85f8cf7b94abae52bcd25/pyproject.toml#L6
that is a separated package on pypi
https://pypi.org/project/oldest-supported-numpy/
There was a problem hiding this comment.
Indeed this is actually for the ciso project that has oldest-supported-numpy not only in build-system requirements , but in dependencies as well:
dependencies = [
"oldest-supported-numpy ; python_version < '3.9'",
"numpy>=2.0.0rc1 ; python_version >= '3.9'",
]
gsw has only numpy>=1.21 in dependencies (oldest-supported-numpy is only in the build-system).
oldest-supported-numpy doesn't appear the run requirements in that case.
There was a problem hiding this comment.
It's ok to have in pyproject.toml
However what this appears to be testing is whether this is added to requirements/host and requirements/run. The latter doesn't make sense
There was a problem hiding this comment.
it is going to appear in the requirements run because oldest-supported-numpy is specified in the dependencies section of the pyproject.toml. If it is was only in build section of pyproject.toml that would appear only in host then.
It is possible to do a workaround and always remove it from the requirements/run and always let it in host, but I am just not so sure if it covers all scenarios, what do you think?
There was a problem hiding this comment.
We should remove oldest-supported-numpy whenever it is seen. That's used by wheels specifically to configure builds with specific numpy versions (not sure why a wheel would use oldest-supported-numpy at runtime unless they are some kind of build tool)
In any event it doesn't make sense in the Conda case where we configure NumPy versions used in some conda_build_config.yaml or other variants
On the Conda side, we need only add numpy (unconstrained) to requirements/host and copy over any dependencies value of numpy to requirements/run
There was a problem hiding this comment.
ok, gotcha
That is pretty much a new PR to do this workaround as it was not a requirement before.
There was a problem hiding this comment.
Gotcha thanks for the context! 🙏
The issue is oldest-supported-numpy doesn't exist in Conda. So if Grayskull adds it to recipes, they will be broken. Maintainers will need to know they can clean this out to fix the issue
In any event, we can discuss more in the new issue (thanks for raising! 🙏): #553
Description
Some tests are currently broken on
main. Trying to fix those:test_short_license_id(DEC-3-Clause' detected instead ofBSD-3-Clause`) - thanks to @dholth (commit from Generate recipe from project tree using pypa/build #541)args.url_pypi_metadatahas a default value and will never be empty)recipe_dir)test_poetry_langchain_snapshot: replace pypi.io with pypi.org (pypi.org is the official domain)test_console_script_toml_formatfor python 3.12 right now. We need to find another package for that test. Do you know any?test_merge_pypi_sdist_metadatafor python 3.12: bump gsw versiontest_injection_distutils_compiler_gswfor python 3.12: bump gsw version - note that packages can't be retrieved from pyproject.toml right nowtest_ciso_recipefor python 3.12: bump ciso version