feat: Add S3 support #1008
feat: Add S3 support #1008
Conversation
There was a problem hiding this comment.
a current limitation is that we need to have one shared credential for each bucket we access with this setup.
we could also make the config-file and profile channel-dependent but i think as a first version, this is okay, wdyt?
There was a problem hiding this comment.
If you would add specific config per channel what would that look like? Does it change the API much?
There was a problem hiding this comment.
we could also make the
config-fileandprofilechannel-dependent
I think this comment was based on an outdated version of the code. Still, we do not support channel-specific configuration yet. Did you already think about an API @pavelzw?
| # - { name: "Linux-mips", target: mips-unknown-linux-musl, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
| # - { name: "Linux-mipsel", target: mipsel-unknown-linux-musl, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
| # - { name: "Linux-mips64", target: mips64-unknown-linux-muslabi64, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
| # - { name: "Linux-mips64el", target: mips64el-unknown-linux-muslabi64, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
|
|
||
| # - { name: "Linux-powerpc", target: powerpc-unknown-linux-gnu, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
| # - { name: "Linux-powerpc", target: powerpc-unknown-linux-gnu, os: ubuntu-latest, use-cross: true, skip-tests: true } |
There was a problem hiding this comment.
Should this be reverted?
There was a problem hiding this comment.
imo it's cleaner now (my yaml linter fixed this), since it's consistent with the previous line comments.
| - { name: "Linux-powerpc64", target: powerpc64-unknown-linux-gnu, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
| - { name: "Linux-powerpc64le", target: powerpc64le-unknown-linux-gnu, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
|
|
||
| - { name: "Linux-s390x", target: s390x-unknown-linux-gnu, os: ubuntu-latest, use-cross: true, skip-tests: true } | ||
|
|
||
| - { name: "macOS-x86_64", target: x86_64-apple-darwin, os: macOS-latest } | ||
| - { name: "macOS-aarch64", target: aarch64-apple-darwin, os: macOS-latest, skip-tests: true } |
There was a problem hiding this comment.
Should this be reverted?
There was a problem hiding this comment.
@pavelzw activated the tests on macOS-aarch64; is there a reason not to execute them?
There was a problem hiding this comment.
If you would add specific config per channel what would that look like? Does it change the API much?
Description
xref #960
#960 (comment)